This accomplishes a couple things:
- Enables verbose builds for both the luamake and luals build phases
- Supports ccache during the luamake build phase
The verbose builds should happen; we always want to see the actual commands wherever possible.
The ccache support looks kludgey because it is kludgey, but it’s an approach that’s used in multiple ports, and ${CCACHE_BIN} defaults to ”” for precisely this scenario.
That said, I haven’t yet figured out how to get that into the LuaLS build phase. It seems like it’s driven by a generated file, but that file is created during the build phase, so it’s really unclear when (and *how*) to patch the file.
IIRC, this is how the lua-language-server built during its prehistoric phase—the luamake phase is ccache’d, and the luals phase is not.
Anyway, Dave what are your thoughts on this?