Differential D56502

nfs: make no-IP kernels compile
ClosedPublic
Actions

Authored by bz on Apr 18 2026, 1:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jun 15, 9:04 PM

	Unknown Object (File)
	Sun, Jun 14, 11:03 AM

	Unknown Object (File)
	Mon, Jun 8, 12:28 PM

	Unknown Object (File)
	Thu, Jun 4, 8:19 AM

	Unknown Object (File)
	Wed, Jun 3, 9:40 PM

	Unknown Object (File)
	May 16 2026, 7:01 PM

	Unknown Object (File)
	May 16 2026, 7:01 PM

	Unknown Object (File)
	May 16 2026, 6:58 PM

View All 29 Files

Subscribers

Details

Reviewers

Commits

rG395c8f0855e0: nfs: make no-IP kernels compile

Summary

Compiling a LINT-NOIP kernel (assumingly also a NOINET) port and ip
are set but not used in nfsrv_getclientipaddr().

Hide the variables behind #ifdef checks and do likewise for the parsing
results. Admittingly the code probably wants to be rewritten one day.

Found with: gcc15 tinderbox build
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Apr 18 2026, 1:34 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 18 2026, 1:34 PM

bz requested review of this revision.Apr 18 2026, 1:34 PM

Harbormaster completed remote builds in B72325: Diff 175838.Apr 18 2026, 1:34 PM

bz added a subscriber: jhb.Apr 18 2026, 1:36 PM

Actually that function should go away completely.
It is only used for NFSv4.0, which is now considered
deprecated in favour of NFSv4.1/4.2 and it only
deals with a callback address. Callback addresses
are used for NFSv4.0 only when delegations are
enabled and NFSv4.0 delegations are basically
useless.

I've had disabling callbacks/delegations for
NFSv4.0 on my to-do list for a while, but I
haven't gotten around to it.

Until then, this commit looks fine to me.

This revision is now accepted and ready to land.Apr 18 2026, 2:31 PM

Closed by commit rG395c8f0855e0: nfs: make no-IP kernels compile (authored by bz). · Explain WhyApr 20 2026, 11:16 AM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG395c8f0855e0: nfs: make no-IP kernels compile.

Revision Contents
Changeset List

Path

Size

sys/

fs/

nfsserver/

nfs_nfsdstate.c

10 lines

Diff 175886

sys/fs/nfsserver/nfs_nfsdstate.c

Loading...