Differential D56492

p9fs: Move UMA zone initialization to VFS module lifecycle
ClosedPublic
Actions

Authored by arichardson on Sat, Apr 18, 5:56 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 15, 3:25 AM

	Unknown Object (File)
	Thu, May 14, 6:35 PM

	Unknown Object (File)
	Thu, May 14, 5:22 PM

	Unknown Object (File)
	Tue, May 12, 12:29 PM

	Unknown Object (File)
	Tue, May 12, 10:53 AM

	Unknown Object (File)
	Tue, May 12, 2:38 AM

	Unknown Object (File)
	Sat, May 9, 4:34 PM

	Unknown Object (File)
	Sat, May 9, 4:26 PM

View All 20 Files

Subscribers

Details

Reviewers

kib
markj

Group Reviewers

Commits

rG1ed2ef42e017: p9fs: Move UMA zone initialization to VFS module lifecycle

Summary

Previously, the UMA zones required for 9P requests (p9fs_buf_zone,
p9fs_req_zone, etc.) were initialized and destroyed in the
virtio_p9fs transport module. This caused issues when unloading
the core p9fs module.

This change moves p9_init_zones() and p9_destroy_zones() into
p9fs_init() and p9fs_uninit() inside p9fs_vfsops.c so that they
are correctly bound to the VFS filesystem module lifecycle via
vfs_modevent, aligning p9fs with standard FreeBSD VFS semantics.

Found while fixing https://github.com/CTSRD-CHERI/cheribsd/issues/2617.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Sat, Apr 18, 5:56 AM

Herald added a subscriber: imp. · View Herald TranscriptSat, Apr 18, 5:56 AM

Harbormaster completed remote builds in B72313: Diff 175815.Sat, Apr 18, 5:56 AM

arichardson requested review of this revision.Sat, Apr 18, 5:56 AM

Herald added a reviewer: cheri. · View Herald TranscriptSat, Apr 18, 5:56 AM

Herald added a reviewer: cheri. · View Herald Transcript

arichardson added a parent revision: D56497: virtio_p9fs: Fix kernel panic on module unload.Sat, Apr 18, 6:01 AM

arichardson added child revisions: D56495: p9fs: Refactor buffer allocations to avoid zeroing large payloads, D56494: p9fs: Fix creating files with restrictive permissions, D56493: p9fs: implement basic pathconf support.

kib accepted this revision.Sat, Apr 18, 7:50 PM

This revision is now accepted and ready to land.Sat, Apr 18, 7:50 PM

Closed by commit rG1ed2ef42e017: p9fs: Move UMA zone initialization to VFS module lifecycle (authored by arichardson). · Explain WhyThu, May 7, 5:03 AM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rG1ed2ef42e017: p9fs: Move UMA zone initialization to VFS module lifecycle.

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

p9fs/

3 lines

fs/

p9fs/

4 lines

Diff 177347

sys/dev/virtio/p9fs/virtio_p9fs.c

Loading...

sys/fs/p9fs/p9fs_vfsops.c

Loading...