kevent: do not check knote lists being empty before removing a knote
ClosedPublic
Actions

Authored by kib on Apr 10 2026, 8:30 AM.

Tags

None

Referenced Files

	F163279653: D56341.diff
	Tue, Jul 21, 4:48 PM

	Unknown Object (File)
	Wed, Jul 15, 7:16 AM

	Unknown Object (File)
	Wed, Jul 15, 7:16 AM

	Unknown Object (File)
	Sun, Jul 5, 5:46 PM

	Unknown Object (File)
	Mon, Jun 29, 12:00 PM

	Unknown Object (File)
	Mon, Jun 22, 12:00 AM

	Unknown Object (File)
	Jun 20 2026, 9:11 PM

	Unknown Object (File)
	Jun 20 2026, 9:27 AM

View All 38 Files

Subscribers

imp

olce

Details

Reviewers

kevans
markj

Commits

rG31069fdbdae1: kevent: do not check knote lists being empty before removing a knote

Summary

If knote belongs to the list, there is no reason to check for the list
emptiness.  On the other hand, if the knote does not belong to the list,
then checking for emptiness is not enough since there might be a
different knote there.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Apr 10 2026, 8:30 AM

Herald added subscribers: olce, imp. · View Herald TranscriptApr 10 2026, 8:30 AM

kib requested review of this revision.Apr 10 2026, 8:30 AM

markj accepted this revision.Apr 10 2026, 11:46 AM

This revision is now accepted and ready to land.Apr 10 2026, 11:46 AM

kevans accepted this revision.Apr 10 2026, 2:04 PM

Closed by commit rG31069fdbdae1: kevent: do not check knote lists being empty before removing a knote (authored by kib). · Explain WhyApr 10 2026, 2:35 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG31069fdbdae1: kevent: do not check knote lists being empty before removing a knote.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_event.c

3 lines

vfs_aio.c

6 lines

Diff 175228

View Options

sys/kern/kern_event.c