kevent: do not check knote lists being empty before removing a knote
ClosedPublic
Actions

Authored by kib on Fri, Apr 10, 8:30 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 16, 9:56 PM

	Unknown Object (File)
	Thu, Apr 16, 2:54 PM

	Unknown Object (File)
	Wed, Apr 15, 1:22 PM

	Unknown Object (File)
	Wed, Apr 15, 7:55 AM

	Unknown Object (File)
	Tue, Apr 14, 2:43 PM

	Unknown Object (File)
	Tue, Apr 14, 2:43 PM

	Unknown Object (File)
	Sat, Apr 11, 5:22 AM

	Unknown Object (File)
	Fri, Apr 10, 11:36 AM

View All 9 Files

Subscribers

imp

olce

Details

Reviewers

kevans
markj

Commits

rG31069fdbdae1: kevent: do not check knote lists being empty before removing a knote

Summary

If knote belongs to the list, there is no reason to check for the list
emptiness.  On the other hand, if the knote does not belong to the list,
then checking for emptiness is not enough since there might be a
different knote there.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Fri, Apr 10, 8:30 AM

Herald added subscribers: olce, imp. · View Herald TranscriptFri, Apr 10, 8:30 AM

kib requested review of this revision.Fri, Apr 10, 8:30 AM

markj accepted this revision.Fri, Apr 10, 11:46 AM

This revision is now accepted and ready to land.Fri, Apr 10, 11:46 AM

kevans accepted this revision.Fri, Apr 10, 2:04 PM

Closed by commit rG31069fdbdae1: kevent: do not check knote lists being empty before removing a knote (authored by kib). · Explain WhyFri, Apr 10, 2:35 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG31069fdbdae1: kevent: do not check knote lists being empty before removing a knote.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_event.c

3 lines

vfs_aio.c

6 lines

Diff 175228

View Options

sys/kern/kern_event.c