dup(2): document the handling of filedescriptor flags
ClosedPublic
Actions

Authored by kib on Sat, Mar 28, 8:53 AM.

Details

Reviewers

emaste
markj

Commits

rG6cc99baea607: dup(2): document the handling of filedescriptor flags

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Sat, Mar 28, 8:53 AM

Herald added subscribers: ziaee, imp. · View Herald TranscriptSat, Mar 28, 8:53 AM

kib requested review of this revision.Sat, Mar 28, 8:53 AM

markj added inline comments.Sat, Mar 28, 8:58 AM

lib/libc/gen/dup3.3
55	In fact it is unconditionally preserved, kern_dup() does newfde->fde_flags = (oldfde->fde_flags & ~(UF_EXCLOSE \| UF_FOCLOSE)) \| fddup_to_fde_flags(flags);
lib/libsys/dup.2
85	The resolve-beneath flag is preserved.

Flip the description.

markj accepted this revision.Sat, Mar 28, 9:08 AM

This revision is now accepted and ready to land.Sat, Mar 28, 9:08 AM

Closed by commit rG6cc99baea607: dup(2): document the handling of filedescriptor flags (authored by kib). · Explain WhySat, Mar 28, 9:09 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG6cc99baea607: dup(2): document the handling of filedescriptor flags.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

dup3.3

2 lines

libsys/

dup.2

5 lines

Diff 174429

View Options

lib/libc/gen/dup3.3