Page MenuHomeFreeBSD
Differential D5601

Disable symbols for compat syscalls on arm64.
ClosedPublic
Actions

Authored by brooks on Mar 10 2016, 5:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 4:14 PM
Unknown Object (File)
Dec 22 2024, 12:11 PM
Unknown Object (File)
Dec 22 2024, 12:05 PM
Unknown Object (File)
Nov 29 2024, 3:51 AM
Unknown Object (File)
Nov 26 2024, 7:38 AM
Unknown Object (File)
Nov 9 2024, 1:00 PM
Unknown Object (File)
Oct 22 2024, 11:29 AM
Unknown Object (File)
Oct 22 2024, 11:29 AM
View All 57 Files
Subscribers
emaste
imp

Details

Reviewers
emaste
andrew
imp
Summary

These symbols were never shipped since arm64 exists only on 11+.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2844
Build 2868: arc lint + arc unit

Event Timeline

brooks updated this revision to Diff 14214.Mar 10 2016, 5:11 AM
brooks retitled this revision from to Disable symbols for compat syscalls on arm64..
brooks updated this object.
brooks edited the test plan for this revision. (Show Details)
brooks added a reviewer: andrew.
Herald added subscribers: emaste, imp. · View Herald TranscriptMar 10 2016, 5:11 AM
imp accepted this revision.Mar 10 2016, 5:18 AM
imp added a reviewer: imp.

Right thing to do. Not 100% sure I like the means, but I love the sentiment.

This revision is now accepted and ready to land.Mar 10 2016, 5:18 AM
andrew accepted this revision.Mar 10 2016, 10:24 PM
andrew edited edge metadata.

Tested on the Cavium in Sentex.

I would expect we could do something similar on riscv, and maybe arm.

emaste added a comment.Mar 10 2016, 10:28 PM

I've been looking at something similar in D5572 to fix WITHOUT_SYMVER to turn off __sym_compat unconditionally.

brooks added a comment.Mar 11 2016, 1:10 AM
In D5601#119572, @emaste wrote:

I've been looking at something similar in D5572 to fix WITHOUT_SYMVER to turn off __sym_compat unconditionally.

I think we probably want a combination of the two with a MIN_COMPAT_RELEASE or similar variable and a series of COMPAT# defines.

emaste accepted this revision.Mar 14 2016, 12:38 AM
emaste added a reviewer: emaste.

I think we probably want a combination of the two with a MIN_COMPAT_RELEASE or similar variable and a series of COMPAT# defines.

I agree that sounds like a good further refinement but think this looks like a reasonable start. I'll probably also commit the Makefile changes from D5572.

emaste mentioned this in D5650: libc: add per-arch backwards compatability symbol control.Mar 16 2016, 2:45 PM
andrew closed this revision.Apr 6 2016, 4:11 PM

rS297619

Revision Contents
Changeset List

PathSize
lib/
libc/
aarch64/
gen/
2 lines
sys/
2 lines
gen/
6 lines
include/
2 lines

Diff 14214

View Options

lib/libc/aarch64/gen/Makefile.inc

Loading...
View Options

lib/libc/aarch64/sys/Makefile.inc

Loading...
View Options

lib/libc/gen/semctl.c

Loading...
View Options

lib/libc/include/compat.h

Loading...