acpi.4: Update sysctl descriptions for new stypes
ClosedPublic
Actions

Authored by obiwac on Sat, Mar 21, 3:39 AM.

Details

Reviewers

ziaee
markj
olce

Commits

rG2547f9720221: acpi.4: Update sysctl descriptions for new stypes

Summary

The previous S1-S5 options are still accepted for compatibility, but they are now deprecated in favour of the new generic sleep types.

I still need to create a manpage to document the new sysctls added in c43473dc9b8349103f78107300457ca35e437882 ("sys/power: Generic sleep types"), but this fixes an inaccuracy at least.

Also also the logic for selecting between s2mem and s2idle will have to change eventually, because we'll want to enable s2idle by default even on systems supporting s2mem if their FADT reports support for S0ix.

Reported by: markj
Fixes: 97d152698f48 ("acpi: Use sleep types defined in sys/power.h")
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

obiwac created this revision.Sat, Mar 21, 3:39 AM

Herald added a subscriber: imp. · View Herald TranscriptSat, Mar 21, 3:39 AM

obiwac requested review of this revision.Sat, Mar 21, 3:39 AM

Harbormaster completed remote builds in B71612: Diff 174064.Sat, Mar 21, 3:39 AM

obiwac edited the summary of this revision. (Show Details)Sat, Mar 21, 3:40 AM

It would be nice to describe somewhere how the new states map to ACPI sleep states.

This revision is now accepted and ready to land.Sat, Mar 21, 5:08 AM

It would be nice to describe somewhere how the new states map to ACPI sleep states.

Yeah, and this should probably be in acpi(4). I will hold off on this for now before I finalize the stype names and I create the power manpage, because there might still be some shuffling around.

Closed by commit rG2547f9720221: acpi.4: Update sysctl descriptions for new stypes (authored by obiwac). · Explain WhySat, Mar 21, 5:16 AM

This revision was automatically updated to reflect the committed changes.

obiwac added a commit: rG2547f9720221: acpi.4: Update sysctl descriptions for new stypes.