Page MenuHomeFreeBSD

fenv.h: stop declaring feclearexcept() extern inline
Needs ReviewPublic

Authored by kib on Thu, Mar 19, 8:42 PM.
Tags
None
Referenced Files
F149523643: D55975.diff
Wed, Mar 25, 12:34 AM
F149523621: D55975.diff
Wed, Mar 25, 12:34 AM
F149511765: D55975.diff
Tue, Mar 24, 11:09 PM
Unknown Object (File)
Sat, Mar 21, 4:09 PM
Unknown Object (File)
Fri, Mar 20, 10:42 PM
Subscribers

Details

Reviewers
emaste
dim
andrew
Summary
The function is already exported from libm.  We only need to stop
declare it extern inline, and instead provide a macro which uses the
internal inline function __feclearexcept_int() instead.

PR:     277958

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib requested review of this revision.Thu, Mar 19, 8:42 PM

I only handled x86 for start. After everybody is fine with the patch, I will add other arches.

Yeah, this looks fine to me. (Though I got confused initially by the _int suffix, until I understood that it's shorthand for internal... I was mislead by the int argument)

This revision is now accepted and ready to land.Thu, Mar 19, 8:48 PM
This revision now requires review to proceed.Sun, Mar 22, 1:23 AM

Do we need to handle the rest of the fenv functions same, they all are extern inline. Then we can remove the requirement to have gcc semantic for inline as a bonus.