Page MenuHomeFreeBSD

fenv.h: stop declaring feclearexcept() extern inline
ClosedPublic

Authored by kib on Mar 19 2026, 8:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 30, 2:08 PM
Unknown Object (File)
Fri, May 29, 11:21 AM
Unknown Object (File)
Wed, May 27, 7:21 PM
Unknown Object (File)
Wed, May 27, 12:46 PM
Unknown Object (File)
Wed, May 27, 7:56 AM
Unknown Object (File)
Tue, May 26, 5:37 PM
Unknown Object (File)
May 14 2026, 11:42 AM
Unknown Object (File)
May 14 2026, 11:42 AM
Subscribers

Details

Summary
The function is already exported from libm.  We only need to stop
declare it extern inline, and instead provide a macro which uses the
internal inline function __feclearexcept_int() instead.

PR:     277958

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Mar 19 2026, 8:42 PM

I only handled x86 for start. After everybody is fine with the patch, I will add other arches.

Yeah, this looks fine to me. (Though I got confused initially by the _int suffix, until I understood that it's shorthand for internal... I was mislead by the int argument)

This revision is now accepted and ready to land.Mar 19 2026, 8:48 PM
This revision now requires review to proceed.Mar 22 2026, 1:23 AM

Do we need to handle the rest of the fenv functions same, they all are extern inline. Then we can remove the requirement to have gcc semantic for inline as a bonus.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 26 2026, 11:42 PM
This revision was automatically updated to reflect the committed changes.