Page MenuHomeFreeBSD

fenv.h: stop declaring feclearexcept() extern inline
ClosedPublic

Authored by kib on Mar 19 2026, 8:42 PM.
Tags
None
Referenced Files
F165249313: D55975.diff
Fri, Aug 7, 4:19 AM
F165186066: D55975.diff
Thu, Aug 6, 2:50 PM
Unknown Object (File)
Mon, Aug 3, 2:32 PM
Unknown Object (File)
Sun, Aug 2, 12:35 AM
Unknown Object (File)
Thu, Jul 23, 1:53 AM
Unknown Object (File)
Mon, Jul 20, 11:22 AM
Unknown Object (File)
Wed, Jul 15, 5:44 AM
Unknown Object (File)
Wed, Jul 15, 5:44 AM
Subscribers

Details

Summary
The function is already exported from libm.  We only need to stop
declare it extern inline, and instead provide a macro which uses the
internal inline function __feclearexcept_int() instead.

PR:     277958

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Mar 19 2026, 8:42 PM

I only handled x86 for start. After everybody is fine with the patch, I will add other arches.

Yeah, this looks fine to me. (Though I got confused initially by the _int suffix, until I understood that it's shorthand for internal... I was mislead by the int argument)

This revision is now accepted and ready to land.Mar 19 2026, 8:48 PM
This revision now requires review to proceed.Mar 22 2026, 1:23 AM

Do we need to handle the rest of the fenv functions same, they all are extern inline. Then we can remove the requirement to have gcc semantic for inline as a bonus.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 26 2026, 11:42 PM
This revision was automatically updated to reflect the committed changes.