Paths

Table of Contentst

Differential D55732

linuxkpi: Add mising functions in <linux/kmsg_dump.h>
AcceptedPublic
Actions

Authored by dumbbell on Sun, Mar 8, 1:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Mar 12, 2:00 PM

	Unknown Object (File)
	Wed, Mar 11, 7:15 AM

	Unknown Object (File)
	Wed, Mar 11, 4:57 AM

Subscribers

Details

Reviewers

emaste
bz

Group Reviewers

Summary

The DRM generic code started to use kmsg_dump_get_buffer() and kmsg_dump_rewind() in Linux 6.11.

This is part of the update of DRM drivers to Linux 6.11.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell created this revision.Sun, Mar 8, 1:20 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptSun, Mar 8, 1:20 PM

dumbbell requested review of this revision.Sun, Mar 8, 1:20 PM

emaste added inline comments.Sun, Mar 8, 3:47 PM

sys/compat/linuxkpi/common/include/linux/kmsg_dump.h
91	`Unknown` if we want to return a string matching what Linux would do, or perhaps `Unimplemented`

dumbbell marked an inline comment as done.Sun, Mar 8, 8:38 PM

dumbbell added inline comments.

sys/compat/linuxkpi/common/include/linux/kmsg_dump.h
91	The function returns `"Disabled"` on Linux when `CONFIG_PRINTK` is not defined. That’s what I replicated for our non-implemented functions. I will change that to "Unknown".

Address comment from @emaste

emaste accepted this revision.Mon, Mar 9, 1:11 AM

emaste added inline comments.

sys/compat/linuxkpi/common/include/linux/kmsg_dump.h
91	Oh, missed that. In that case I'm fine with `Disabled` too.

This revision is now accepted and ready to land.Mon, Mar 9, 1:11 AM

bz accepted this revision.Mon, Mar 9, 7:37 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

42 lines

Diff 173382

sys/compat/linuxkpi/common/include/linux/kmsg_dump.h

Loading...