libc/{i386,amd64}: Do not export .cerror when building WITHOUT_SYMVER
ClosedPublic
Actions

Authored by emaste on Mar 7 2016, 3:41 PM.

Details

Reviewers

kib
davide
jilles

Commits

rS296474: libc/{i386,amd64}: Do not export .cerror when building WITHOUT_SYMVER

Summary

Further to r240152 (i386) and r240178 (amd64), hide the .cerror symbol so that it is not exported by libc.so, if symbol versioning is not in use. Without this change libc contains .text relocations for .cerror, as described in LLVM PR 26813 (http://llvm.org/pr26813).

PR: 207712
Submitted by: Rafael Espíndola

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 14132.Mar 7 2016, 3:41 PM

emaste retitled this revision from to libc/{i386,amd64}: Do not export .cerror when building WITHOUT_SYMVER.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: kib, jilles, davide.

I do not object against this, but note that we do not, and will not, support non-symver builds of libc. The hidden attribute is more useful at the client side, but since all callers are in asm, it makes not difference. Still, normal builds do not export cerror since it is not listed in the symver scripts.

This revision is now accepted and ready to land.Mar 7 2016, 4:00 PM

I agree that we require symver support for FreeBSD itself, and that this change is a no-op in the normal case as .cerror is already not exported (because it is not listed in the symver script). This is only to support FreeBSD derivatives or custom builds with WITHOUT_SYMVER configured via src.conf(5).

jilles accepted this revision.Mar 7 2016, 10:30 PM

jilles edited edge metadata.

Closed by commit rS296474: libc/{i386,amd64}: Do not export .cerror when building WITHOUT_SYMVER (authored by emaste). · Explain WhyMar 8 2016, 12:09 AM

This revision was automatically updated to reflect the committed changes.

emaste mentioned this in D5775: Hide .cerror, .curbrk, .minbrk on WITHOUT_SYMVER arm64.Apr 13 2016, 4:26 PM