80 chanwidth selection in the "40-" case
ClosedPublic
Actions

Authored by bz on Sun, Mar 8, 1:03 AM.

Details

Reviewers

Group Reviewers

Commits

rGf4e018e9a49b: net80211: fix VHT160/80P80/80 chanwidth selection in the "40-" case
rG68fcf0b94c51: net80211: fix VHT160/80P80/80 chanwidth selection in the "40-" case
rG6cfd2b93e680: net80211: fix VHT160/80P80/80 chanwidth selection in the "40-" case

Summary

Depending on the base channel ni_vht_chan2 - ni_vht_chan1 can be
negative. Apply abs() as indicated in the comments right above

| CCFS1 - CCFS0 | = 8  or > 16

in order to fix the channel width selection.

Sponsored by: The FreeBSD Foundation
PR: 293645
Fixes: 4bf049bfeefd9
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Sun, Mar 8, 1:03 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptSun, Mar 8, 1:03 AM

bz requested review of this revision.Sun, Mar 8, 1:03 AM

Harbormaster completed remote builds in B71251: Diff 173323.Sun, Mar 8, 1:03 AM

bz edited the summary of this revision. (Show Details)Sun, Mar 8, 1:07 AM

nice catch!

This revision is now accepted and ready to land.Sun, Mar 8, 1:22 AM

vsasjason_gmail.com added a subscriber: vsasjason_gmail.com.Sun, Mar 8, 12:07 PM

Closed by commit rG6cfd2b93e680: net80211: fix VHT160/80P80/80 chanwidth selection in the "40-" case (authored by bz). · Explain WhySun, Mar 8, 5:08 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG6cfd2b93e680: net80211: fix VHT160/80P80/80 chanwidth selection in the "40-" case.

bz added a commit: rG68fcf0b94c51: net80211: fix VHT160/80P80/80 chanwidth selection in the "40-" case.Wed, Mar 11, 4:53 PM

bz added a commit: rGf4e018e9a49b: net80211: fix VHT160/80P80/80 chanwidth selection in the "40-" case.Wed, Apr 1, 4:34 AM

Revision Contents
Changeset List

Path

Size

sys/

net80211/

ieee80211_ht.c

5 lines

Diff 173371

View Options

sys/net80211/ieee80211_ht.c

net80211: fix VHT160/80P80/80 chanwidth selection in the "40-" caseClosedPublicActions