Page MenuHomeFreeBSD
Differential D55693

llvm-*: Use SYMLINKS for unprefixed LLVM tools, not hard links
ClosedPublic
Actions

Authored by emaste on Mar 6 2026, 5:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 1, 1:27 AM
Unknown Object (File)
Sun, Aug 30, 1:54 PM
Unknown Object (File)
Thu, Aug 20, 6:45 PM
Unknown Object (File)
Wed, Aug 19, 7:42 PM
Unknown Object (File)
Wed, Aug 19, 7:42 PM
Unknown Object (File)
Wed, Aug 19, 7:42 PM
Unknown Object (File)
Wed, Aug 19, 2:33 AM
Unknown Object (File)
Tue, Aug 18, 8:29 PM
View All Files
Subscribers
imp

Details

Reviewers
ivy
dim
Group Reviewers
build
Commits
rGe71bfbe2f58f: llvm-*: Use SYMLINKS for unprefixed LLVM binutils

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Mar 6 2026, 5:58 PM
emaste created this revision.
emaste updated this revision to Diff 173275.Mar 6 2026, 6:02 PM

SYMLINK to the correct llvm-prefixed tool

dim added a comment.Mar 6 2026, 6:04 PM

I'm fine with this, but what is the motivation? Easier packaging?

emaste mentioned this in D55692: llvm-*: Move LLVM_BINUTILS toosl to toolchain package.Mar 6 2026, 6:04 PM
In D55693#1274557, @dim wrote:

I'm fine with this, but what is the motivation? Easier packaging?

Yeah, see the discussion in D55692.

emaste added a child revision: D55692: llvm-*: Move LLVM_BINUTILS toosl to toolchain package.Mar 6 2026, 6:07 PM
dim accepted this revision.Mar 6 2026, 6:08 PM

LGTM

This revision is now accepted and ready to land.Mar 6 2026, 6:08 PM
emaste added a comment.Mar 6 2026, 6:40 PM

Oh we should probably drop the ${BINDIR} from the link targets

emaste updated this revision to Diff 173277.Mar 6 2026, 7:37 PM

Use relative not absolute symlinks

This revision now requires review to proceed.Mar 6 2026, 7:37 PM
ivy accepted this revision.Mar 7 2026, 3:11 AM

seems fine per previous discussion.

This revision is now accepted and ready to land.Mar 7 2026, 3:11 AM
Closed by commit rGe71bfbe2f58f: llvm-*: Use SYMLINKS for unprefixed LLVM binutils (authored by emaste). · Explain WhyMar 11 2026, 1:38 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGe71bfbe2f58f: llvm-*: Use SYMLINKS for unprefixed LLVM binutils.
Herald added a subscriber: imp. · View Herald TranscriptMar 11 2026, 1:38 PM

Revision Contents
Changeset List

PathSize
usr.bin/
clang/
llvm-ar/
3 lines
llvm-cov/
2 lines
llvm-cxxfilt/
2 lines
llvm-nm/
2 lines
llvm-objcopy/
4 lines
llvm-objdump/
2 lines
llvm-readobj/
2 lines
llvm-size/
2 lines
llvm-symbolizer/
2 lines

Diff 173561

View Options

usr.bin/clang/llvm-ar/Makefile

Loading...
View Options

usr.bin/clang/llvm-cov/Makefile

Loading...
View Options

usr.bin/clang/llvm-cxxfilt/Makefile

Loading...
View Options

usr.bin/clang/llvm-nm/Makefile

Loading...
View Options

usr.bin/clang/llvm-objcopy/Makefile

Loading...
View Options

usr.bin/clang/llvm-objdump/Makefile

Loading...
View Options

usr.bin/clang/llvm-readobj/Makefile

Loading...
View Options

usr.bin/clang/llvm-size/Makefile

Loading...
View Options

usr.bin/clang/llvm-symbolizer/Makefile

Loading...