Page MenuHomeFreeBSD
Differential D55693

llvm-*: Use SYMLINKS for unprefixed LLVM tools, not hard links
ClosedPublic
Actions

Authored by emaste on Fri, Mar 6, 5:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 26, 9:53 AM
Unknown Object (File)
Tue, Mar 24, 10:33 AM
Unknown Object (File)
Mon, Mar 23, 9:47 AM
Unknown Object (File)
Sun, Mar 22, 8:18 AM
Unknown Object (File)
Sun, Mar 22, 6:19 AM
Unknown Object (File)
Sat, Mar 21, 8:59 PM
Unknown Object (File)
Sat, Mar 21, 7:32 PM
Unknown Object (File)
Fri, Mar 20, 6:46 AM
View All 21 Files
Subscribers
imp

Details

Reviewers
ivy
dim
Group Reviewers
build
Commits
rGe71bfbe2f58f: llvm-*: Use SYMLINKS for unprefixed LLVM binutils

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Fri, Mar 6, 5:58 PM
emaste created this revision.
emaste updated this revision to Diff 173275.Fri, Mar 6, 6:02 PM

SYMLINK to the correct llvm-prefixed tool

dim added a comment.Fri, Mar 6, 6:04 PM

I'm fine with this, but what is the motivation? Easier packaging?

emaste mentioned this in D55692: llvm-*: Move LLVM_BINUTILS toosl to toolchain package.Fri, Mar 6, 6:04 PM
In D55693#1274557, @dim wrote:

I'm fine with this, but what is the motivation? Easier packaging?

Yeah, see the discussion in D55692.

emaste added a child revision: D55692: llvm-*: Move LLVM_BINUTILS toosl to toolchain package.Fri, Mar 6, 6:07 PM
dim accepted this revision.Fri, Mar 6, 6:08 PM

LGTM

This revision is now accepted and ready to land.Fri, Mar 6, 6:08 PM
emaste added a comment.Fri, Mar 6, 6:40 PM

Oh we should probably drop the ${BINDIR} from the link targets

emaste updated this revision to Diff 173277.Fri, Mar 6, 7:37 PM

Use relative not absolute symlinks

This revision now requires review to proceed.Fri, Mar 6, 7:37 PM
ivy accepted this revision.Sat, Mar 7, 3:11 AM

seems fine per previous discussion.

This revision is now accepted and ready to land.Sat, Mar 7, 3:11 AM
Closed by commit rGe71bfbe2f58f: llvm-*: Use SYMLINKS for unprefixed LLVM binutils (authored by emaste). · Explain WhyWed, Mar 11, 1:38 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGe71bfbe2f58f: llvm-*: Use SYMLINKS for unprefixed LLVM binutils.
Herald added a subscriber: imp. · View Herald TranscriptWed, Mar 11, 1:38 PM

Revision Contents
Changeset List

PathSize
usr.bin/
clang/
llvm-ar/
3 lines
llvm-cov/
2 lines
llvm-cxxfilt/
2 lines
llvm-nm/
2 lines
llvm-objcopy/
4 lines
llvm-objdump/
2 lines
llvm-readobj/
2 lines
llvm-size/
2 lines
llvm-symbolizer/
2 lines

Diff 173561

View Options

usr.bin/clang/llvm-ar/Makefile

Loading...
View Options

usr.bin/clang/llvm-cov/Makefile

Loading...
View Options

usr.bin/clang/llvm-cxxfilt/Makefile

Loading...
View Options

usr.bin/clang/llvm-nm/Makefile

Loading...
View Options

usr.bin/clang/llvm-objcopy/Makefile

Loading...
View Options

usr.bin/clang/llvm-objdump/Makefile

Loading...
View Options

usr.bin/clang/llvm-readobj/Makefile

Loading...
View Options

usr.bin/clang/llvm-size/Makefile

Loading...
View Options

usr.bin/clang/llvm-symbolizer/Makefile

Loading...