Page MenuHomeFreeBSD
Differential D5569

pmap arm64: fixing pmap_invalidate_range
ClosedPublic
Actions

Authored by wma on Mar 7 2016, 11:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 21, 2:40 AM
Unknown Object (File)
Mon, Apr 20, 6:10 PM
Unknown Object (File)
Sun, Apr 19, 5:35 PM
Unknown Object (File)
Mon, Apr 13, 9:29 PM
Unknown Object (File)
Mon, Apr 13, 1:47 PM
Unknown Object (File)
Mon, Apr 13, 12:47 PM
Unknown Object (File)
Sat, Apr 11, 2:23 PM
Unknown Object (File)
Fri, Apr 10, 10:58 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
zbb
der_semihalf.com
andrew
Commits
rS296828: pmap arm64: fixing pmap_invalidate_range
Summary

It seems that if range within one page is given this page will not be
invalidated at all.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wma updated this revision to Diff 14129.Mar 7 2016, 11:25 AM
wma retitled this revision from to pmap arm64: fixing pmap_invalidate_range.
wma updated this object.
wma edited the test plan for this revision. (Show Details)
wma added reviewers: andrew, zbb, der_semihalf.com.
wma set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added subscribers: emaste, imp. · View Herald TranscriptMar 7 2016, 11:25 AM
zbb accepted this revision.Mar 8 2016, 9:23 AM
zbb edited edge metadata.
This revision is now accepted and ready to land.Mar 8 2016, 9:23 AM
andrew edited edge metadata.Mar 10 2016, 5:37 AM

Where are we calling pmap_invalidate_range where the end address is not a multiple of PAGE_SIZE?

wma added a comment.Mar 14 2016, 7:19 AM

Currently, nowhere. But that's not a reason for keeping the function broken. We wanted to use it for segfault debugging during buildworld and it's better to cleanup the code rather than workaround xxx_range function wherever is called.

Closed by commit rS296828: pmap arm64: fixing pmap_invalidate_range (authored by wma). · Explain WhyMar 14 2016, 7:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm64/
arm64/
6 lines

Diff 14312

View Options

head/sys/arm64/arm64/pmap.c

Loading...