Page MenuHomeFreeBSD

der_semihalf.com (Dominik Ermel)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 30 2015, 2:52 PM (320 w, 2 d)

Recent Activity

Sep 5 2016

der_semihalf.com retitled D7787: arm: removing redundant return in minidumpsys from to arm: removing redundant return in minidumpsys.
Sep 5 2016, 12:34 PM

Jul 15 2016

der_semihalf.com added a comment to D6879: bsdinstall: partedit allows user to modify bootable partition type to non-supported type without warning.

Thanks! Please go ahead and commit.

Jul 15 2016, 11:34 AM

Jun 29 2016

der_semihalf.com added inline comments to D6853: ARM64: bsdinstall support for creating EFI partitions.
Jun 29 2016, 12:09 PM · arm64

Jun 17 2016

der_semihalf.com added a comment to D6879: bsdinstall: partedit allows user to modify bootable partition type to non-supported type without warning.

Thank you for the review.

Jun 17 2016, 9:15 PM
der_semihalf.com retitled D6879: bsdinstall: partedit allows user to modify bootable partition type to non-supported type without warning from to bsdinstall: partedit allows user to modify bootable partition type to non-supported type without warning.
Jun 17 2016, 11:48 AM

Jun 16 2016

der_semihalf.com added a comment to D6853: ARM64: bsdinstall support for creating EFI partitions.

Thank you for reviewing the code.

Jun 16 2016, 9:55 AM · arm64
der_semihalf.com updated the diff for D6853: ARM64: bsdinstall support for creating EFI partitions.

All reviewers comments have been applied.
Booting from ZFS have been removed for now.

Jun 16 2016, 9:54 AM · arm64

Jun 15 2016

der_semihalf.com added inline comments to D6853: ARM64: bsdinstall support for creating EFI partitions.
Jun 15 2016, 5:55 PM · arm64
der_semihalf.com added a comment to D6853: ARM64: bsdinstall support for creating EFI partitions.

Partition scheme screen from Thunder:

Jun 15 2016, 5:51 PM · arm64
der_semihalf.com retitled D6853: ARM64: bsdinstall support for creating EFI partitions from to ARM64: bsdinstall support for creating EFI partitions.
Jun 15 2016, 5:45 PM · arm64
der_semihalf.com added a comment to D6798: ARM64: Fixing bug in memstick img creation script.

Oh.sorry True. This one is really old.

Jun 15 2016, 4:34 PM · arm64
der_semihalf.com added a comment to D6798: ARM64: Fixing bug in memstick img creation script.

Just try this:

~/tmp/mkimg]$ dd if=/dev/zero of=efi.img.part bs=1024 count=$((1024*4))
4096+0 records in
4096+0 records out
4194304 bytes transferred in 0.055327 secs (75809436 bytes/sec)
~/tmp/mkimg]$ dd if=/dev/zero of=other.img.part bs=1024 count=$((1024*4))
4096+0 records in
4096+0 records out
4194304 bytes transferred in 0.050146 secs (83641674 bytes/sec)
~/tmp/mkimg]$ mkimg -s mbr efi:=efi.img.part freebsd:=other.img.part  -o final.img
~/tmp/mkimg]$ mkimg -s mbr -p efi:=efi.img.part -p freebsd:=other.img.part  -o final.img
mkimg: partition 1: Invalid argument
~/tmp/mkimg]$ mkimg -s MBR -p efi:=efi.img.part -p freebsd:=other.img.part  -o final.img
mkimg: partition 1: Invalid argument
~/tmp/mkimg]$ mkimg -s gtp -p efi:=efi.img.part -p freebsd:=other.img.part  -o final.img
mkimg: scheme: Invalid argument
~/tmp/mkimg]$ mkimg -s gpt -p efi:=efi.img.part -p freebsd:=other.img.part  -o final.img
~/tmp/mkimg]$ echo $?
0
~/tmp/mkimg]$
Jun 15 2016, 4:09 PM · arm64
der_semihalf.com added a comment to D6798: ARM64: Fixing bug in memstick img creation script.

The script does not work at all because the syntax of mkimg is broken. This script generates no image when there is "-s mbr". You are not able to create memstick.img with this script. I have been able to create GPT type memstick and boot it of SATA and USB flash drive on ThunderX.

Jun 15 2016, 3:46 PM · arm64
der_semihalf.com added a comment to D6798: ARM64: Fixing bug in memstick img creation script.

ed, gjb, wma can you please proceed with review? Do you have any more comments?

Jun 15 2016, 9:46 AM · arm64

Jun 13 2016

der_semihalf.com added a comment to D6798: ARM64: Fixing bug in memstick img creation script.

The oldest firmwre version, I have tested, is:
Firmware Version: 2016-02-12 12:59:55
BDK Version: thunder-release-v1.20-2-gd555028, Branch: remotes/origin/thunder-dev, Built: pią, 12 lut 2016, 11:58:38 UTC
("pią 12 lut" is "Fri Feb 12")

Jun 13 2016, 10:28 AM · arm64

Jun 11 2016

der_semihalf.com added a comment to D6798: ARM64: Fixing bug in memstick img creation script.

The problem was not with the EFI. The gpart, that has been called by, mkimg refused to create such combination of partitions.
When I have invoked "make memstick (...)" I got memstick.img.part prepared but mkimg fails producing memstick.img.
When I have tested the mkimg command line it seemd that the "-s mbr" does not want to work with "-p efi:=(...)".
producing error: "mkimg: partition 1: Invalid argument" . Changing the "-s mbr" to "-s gpt" fixed the problem and created image did boot.
I did not know abot the problem with UUID you have mentioned. I have faced problem creating the img itself - but this is good to know. I wil give you the firmware info on Monday since I have no remote access to board right now.

Jun 11 2016, 2:25 AM · arm64

Jun 10 2016

der_semihalf.com retitled D6798: ARM64: Fixing bug in memstick img creation script from to ARM64: Fixing bug in memstick img creation script.
Jun 10 2016, 8:27 AM · arm64

Apr 1 2016

der_semihalf.com updated the diff for D5726: arm64: bzero has been optimized.

Explanation for x5 zeroing before jumping to "normal" for buffers of size <= 16 has been added.

Apr 1 2016, 11:23 AM · arm64
der_semihalf.com added a comment to D5726: arm64: bzero has been optimized.

Something more to fix?

Apr 1 2016, 10:02 AM · arm64

Mar 31 2016

der_semihalf.com updated the diff for D5726: arm64: bzero has been optimized.

Reviewers comments have been applied.

Mar 31 2016, 8:35 AM · arm64
der_semihalf.com added a comment to D5726: arm64: bzero has been optimized.
In D5726#123719, @kib wrote:

Initial NULL check is still there.

Mar 31 2016, 7:01 AM · arm64

Mar 30 2016

der_semihalf.com added a comment to D5726: arm64: bzero has been optimized.

Do you have any more comments regarding the latest changes?
I would like to move forward with this and need to know if you are OK with the soultion or need some changes to it.

Mar 30 2016, 7:47 AM · arm64

Mar 29 2016

der_semihalf.com updated the diff for D5741: arm64: pagezero improvement.

Provided comment as requested.

Mar 29 2016, 9:59 AM · arm64
der_semihalf.com added a comment to D5741: arm64: pagezero improvement.
In D5741#123261, @kib wrote:

There seems to be some issues with spaces/tabs between instructions and operands.

Mar 29 2016, 9:52 AM · arm64
der_semihalf.com updated the diff for D5741: arm64: pagezero improvement.

All reviewers' comments have been applited.

Mar 29 2016, 9:27 AM · arm64
der_semihalf.com updated the diff for D5741: arm64: pagezero improvement.

All of reviewers' comments have been applied.

Mar 29 2016, 8:35 AM · arm64

Mar 27 2016

der_semihalf.com added a comment to D5741: arm64: pagezero improvement.
In D5741#122931, @kib wrote:

Wouldn't it be (much) cleaner to select one of two implementations (dc/stp) e.g. by function pointer ?

Mar 27 2016, 5:35 PM · arm64

Mar 25 2016

der_semihalf.com retitled D5741: arm64: pagezero improvement from to arm64: pagezero improvement.
Mar 25 2016, 6:46 PM · arm64
der_semihalf.com updated the diff for D5726: arm64: bzero has been optimized.

Review comments have been applied with following differences:

  • will jump directly to normal for buffers with size <= 16 rather than 8 as suggested by wma
  • function has not been split because optimized pagezero is in work; which is much more simplier than bzero
Mar 25 2016, 5:52 PM · arm64

Mar 24 2016

der_semihalf.com retitled D5726: arm64: bzero has been optimized from to arm64: bzero has been optimized.
Mar 24 2016, 11:29 AM · arm64
der_semihalf.com updated the diff for D5719: arm64: Fixing user space boudary checking in copyinout.S.

Implemented fixes suggested by kib.

Mar 24 2016, 9:40 AM

Mar 23 2016

der_semihalf.com added a comment to D5719: arm64: Fixing user space boudary checking in copyinout.S.

Because of this I don't see how this would be anything other than an optimisation.

We do not want this kind of optimizations? I do not see why it is worth to engage CPU cycles in action, that is certain to fail. That is sloppy from our side.

Not when it's an optimisation for an uncommon case at the cost of the common case.

Mar 23 2016, 6:01 PM
der_semihalf.com added a comment to D5719: arm64: Fixing user space boudary checking in copyinout.S.

Because of this I don't see how this would be anything other than an optimisation.

Mar 23 2016, 4:48 PM
der_semihalf.com added a comment to D5719: arm64: Fixing user space boudary checking in copyinout.S.

I agree that the solution that you propose is more elegant. And takes less instructions.

Mar 23 2016, 4:20 PM
der_semihalf.com retitled D5719: arm64: Fixing user space boudary checking in copyinout.S from to arm64: Fixing user space boudary checking in copyinout.S.
Mar 23 2016, 2:55 PM

Mar 17 2016

der_semihalf.com added a comment to D5664: ARM64 copyinout improvements.

Can you also try with smaller bs values in dd to show how the performance changes for buffer sizes.

I have tested bs from 4096 to above 1024kB. the 3.6GB has been achievend with 512kB block size; increasing the block size above that does not seem to improve the performance.

Mar 17 2016, 2:49 PM

Jan 18 2016

der_semihalf.com accepted D4976: Update ThunderX PCIe driver to new DTS.

ACK.

Jan 18 2016, 11:38 AM · arm64

Dec 23 2015

der_semihalf.com added a comment to D4324: Support for GZIP compressed modules within kldload.
In D4324#98953, @ngie wrote:

Hi,

Just saw this review. We (Isilon) have a different change that implements this in userspace (IIRC). Is there a reason why this was implemented in the kernel instead?

Thanks,
-NGie

Dec 23 2015, 5:37 AM

Dec 22 2015

der_semihalf.com set the repository for D4324: Support for GZIP compressed modules within kldload to rS FreeBSD src repository - subversion.
Dec 22 2015, 5:55 PM
der_semihalf.com updated the diff for D4324: Support for GZIP compressed modules within kldload.

Following has been fixed according to requests:

  • Panic when unknown file format (non-elf/gzelf) file has been provided.
  • duplicated code has been removed
  • problem with file left open in case of error with gzelf file loading
Dec 22 2015, 5:38 PM

Nov 30 2015

der_semihalf.com retitled D4324: Support for GZIP compressed modules within kldload from to Support for GZIP compressed modules within kldload.
Nov 30 2015, 4:48 PM