Page MenuHomeFreeBSD

net80211: sta: use IEEE80211_STATUS_SUCCESS instead of magic 0
ClosedPublic

Authored by bz on Wed, Mar 4, 8:15 AM.
Tags
None
Referenced Files
F149970002: D55643.diff
Sat, Mar 28, 11:48 AM
Unknown Object (File)
Wed, Mar 18, 4:39 PM
Unknown Object (File)
Mon, Mar 16, 12:23 AM
Unknown Object (File)
Fri, Mar 13, 9:38 PM
Unknown Object (File)
Fri, Mar 13, 9:31 PM
Unknown Object (File)
Mon, Mar 9, 12:44 AM
Unknown Object (File)
Sun, Mar 8, 8:45 AM
Unknown Object (File)
Sun, Mar 8, 8:29 AM

Details

Summary

Rather than using the status != 0 check use the way more descriptive
status != IEEE80211_STATUS_SUCCESS definition. This makes it a lot
more clear what is checked here. While here add a comment in case
of the (Re)Assoc Resp failure as we do not update state in that case
but rely on a timeout which will bounce us back to State 1
(cf. 802.11-2024, Figure 11-23) which means SCAN in our case, rather
than possibly moving us back to AUTH. We will likely have to revisit
this when SAE hits the tree.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable