Page MenuHomeFreeBSD
Differential D55612

capsicum-test: remove stale file
AbandonedPublic
Actions

Authored by oshogbo on Mon, Mar 2, 7:44 AM.
Tags
None
Referenced Files
F146455235: D55612.id.diff
Mon, Mar 2, 8:09 PM
F146448834: D55612.id172996.diff
Mon, Mar 2, 6:56 PM
F146444479: D55612.id.diff
Mon, Mar 2, 6:09 PM
F146437917: D55612.id172996.diff
Mon, Mar 2, 4:50 PM
F146420038: D55612.id.diff
Mon, Mar 2, 1:32 PM
F146417753: D55612.id172996.diff
Mon, Mar 2, 1:02 PM
Unknown Object (File)
Mon, Mar 2, 10:02 AM
Subscribers
imp
jonathan

Details

Reviewers
emaste
asomers

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 71127
Build 68010: arc lint + arc unit

Event Timeline

oshogbo created this revision.Mon, Mar 2, 7:44 AM
Herald added subscribers: jonathan, imp. · View Herald TranscriptMon, Mar 2, 7:44 AM
oshogbo requested review of this revision.Mon, Mar 2, 7:44 AM
Harbormaster completed remote builds in B71127: Diff 172996.Mon, Mar 2, 7:44 AM
oshogbo retitled this revision from capsicum: remove stale file to capsicum-test: remove stale file.Mon, Mar 2, 7:44 AM
oshogbo added reviewers: emaste, asomers.
emaste added a comment.Mon, Mar 2, 2:48 PM

There are tests in here that were Linux-only when originally written but should now be enabled on FreeBSD. I'm indifferent to leaving the file name alone (reflecting where this functionality originally appeared), renaming the file, or moving individual tests to other files but I don't think we should just delete this.

oshogbo added a comment.Mon, Mar 2, 3:00 PM

The support for linux was removed: ba81b33aabff74ad03d5f9f9663c176cf060fa6

oshogbo added a comment.Mon, Mar 2, 3:00 PM

https://cgit.FreeBSD.org/src/commit/?id=fba81b33aabff74ad03d5f9f9663c176cf060fa6

emaste added a comment.Mon, Mar 2, 3:06 PM

Right, my point is that there are tests in this file for functionality that we (now) have -- signalfd, timerfd, memfd, fstatat at least. Those tests should be connected to the build.

asomers added a comment.Mon, Mar 2, 3:25 PM

I'm with @emaste . And in fact, I already have a branch that enables these tests. They don't all pass, however.

oshogbo abandoned this revision.Mon, Mar 2, 5:49 PM

Right, my point is that there are tests in this file for functionality that we (now) have -- signalfd, timerfd, memfd, fstatat at least. Those tests should be connected to the build.

Ah, I see. Ok.

Revision Contents
Changeset List

PathSize
tests/
sys/
capsicum/

Diff 172996

View Options

tests/sys/capsicum/linux.cc

Loading...