Kill armv6hf. Make that the default. Allow CPUTYPE=soft to build the current soft-float abi libraries.
ClosedPublic
Actions

Authored by imp on Mar 4 2016, 6:17 AM.

Details

Reviewers

andrew
bdrewery

Commits

Summary

Note: still need to do libsoft.

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2778
Build 2799: arc lint + arc unit

imp retitled this revision from to Kill armv6hf. Make that the default. Allow CPUTYPE=soft to build the current soft-float abi libraries..

imp updated this object.

imp edited the test plan for this revision. (Show Details)

imp added reviewers: bdrewery, andrew.

imp added inline comments.

lib/clang/clang.build.mk
27	This one TARGET_ARCH is right. All the others should be MACHINE_ARCH...
lib/msun/arm/Makefile.inc
11–13	This may now be redundant. I haven't tested the soft stuff yet.
lib/msun/arm/fenv-vfp.c
31–34	This change is unrelated and could, in theory, be committed separately.

lib/libc/Makefile
105	Will this work with `armeb`?
lib/msun/arm/Makefile.inc
7	These files are only needed to provide support for both the libc softfloat code, and the VFP. They are only needed when building for the `soft` or `softfp` ABIs.
lib/msun/arm/fenv-vfp.c
31–34	I think this is wrong. This file shouldn't be compiled for anything other than the `soft` or `softfp` ABIs. The `hard` ABI will use `fenv.c` directly.

imp added inline comments.Mar 4 2016, 5:04 PM

lib/libc/Makefile
105	Nope. Good catch.
lib/msun/arm/Makefile.inc
7	OK. I understand. I'll rework.
lib/msun/arm/fenv-vfp.c
31–34	Then why do we define __ARM_PCS_VFP at all here?

Update, per andy.

current soft-float abi libraries.

is there more coming for MK_LIBSOFT?

This revision is now accepted and ready to land.Mar 4 2016, 9:03 PM

Fix arm armeb builds.

current soft-float abi libraries.

This revision now requires review to proceed.Mar 4 2016, 11:40 PM

In D5550#118503, @bdrewery wrote:

is there more coming for MK_LIBSOFT?

Yes, but not in this review. I want to get this slice of the puzzle put to bed then move onto libsoft / MK_LIBSOFT.

bdrewery edited edge metadata.

This revision is now accepted and ready to land.Mar 5 2016, 12:17 AM

lib/libc/arm/aeabi/Makefile.inc
15	This looks wrong, we need to build `aeabi_vfp_*.S` on softfp. They are the VFP implementation we will use when the kernel reports vfp hardware.
lib/msun/arm/fenv-vfp.c
31–34	To tell `fenv.h` to build the vfp version of the functions, i.e. functions that interact with the hardware registers to change the state.