Differential D55405

libfetch: Clean up fetch_info usage
ClosedPublic
Actions

Authored by des on Feb 20 2026, 7:13 PM.

Tags

None

Referenced Files

	F149686989: D55405.id172332.diff
	Thu, Mar 26, 6:41 AM

	Unknown Object (File)
	Fri, Mar 20, 3:26 AM

	Unknown Object (File)
	Fri, Mar 20, 3:26 AM

	Unknown Object (File)
	Fri, Mar 20, 3:26 AM

	Unknown Object (File)
	Tue, Mar 17, 7:09 AM

	Unknown Object (File)
	Fri, Mar 13, 2:03 AM

	Unknown Object (File)
	Wed, Mar 11, 8:04 AM

	Unknown Object (File)
	Wed, Mar 11, 7:09 AM

View All 18 Files

Subscribers

Details

Reviewers

Commits

rG458776896fc4: libfetch: Clean up fetch_info usage
rG5c80cdb120b6: libfetch: Clean up fetch_info usage
rGcee22ac13c7d: libfetch: Clean up fetch_info usage
rG1b7c4d29fdfc: libfetch: Clean up fetch_info usage

Summary

Provide a wrapper for the common if (verbose) fetch_info(...) idiom.

Replace remaining instances of fprintf(stderr, ...) with fetch_info().

Fix a few style nits.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Feb 20 2026, 7:13 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 20 2026, 7:13 PM

des requested review of this revision.Feb 20 2026, 7:13 PM

Harbormaster completed remote builds in B70827: Diff 172332.Feb 20 2026, 7:13 PM

des added a child revision: D55406: libfetch: Fail hard if interrupted while connecting.Feb 20 2026, 7:14 PM

des edited the summary of this revision. (Show Details)Feb 20 2026, 7:22 PM

des edited the summary of this revision. (Show Details)

imp accepted this revision.Feb 20 2026, 11:12 PM

This revision is now accepted and ready to land.Feb 20 2026, 11:12 PM

Closed by commit rG1b7c4d29fdfc: libfetch: Clean up fetch_info usage (authored by des). · Explain WhyFeb 21 2026, 1:19 AM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG1b7c4d29fdfc: libfetch: Clean up fetch_info usage.

des added a commit: rGcee22ac13c7d: libfetch: Clean up fetch_info usage.Thu, Feb 26, 4:23 AM

des added a commit: rG5c80cdb120b6: libfetch: Clean up fetch_info usage.

des added a commit: rG458776896fc4: libfetch: Clean up fetch_info usage.

Revision Contents
Changeset List

Path

Size

lib/

libfetch/

88 lines

Diff 172354

lib/libfetch/common.c

Loading...