Page MenuHomeFreeBSD

Fix bug in VNIC causing phony number of available TX descriptors
ClosedPublic

Authored by zbb on Mar 3 2016, 5:32 PM.
Tags
None
Referenced Files
F103538723: D5535.id.diff
Tue, Nov 26, 6:25 AM
Unknown Object (File)
Wed, Nov 20, 8:26 PM
Unknown Object (File)
Tue, Nov 19, 5:58 AM
Unknown Object (File)
Oct 21 2024, 3:05 AM
Unknown Object (File)
Sep 22 2024, 2:24 AM
Unknown Object (File)
Sep 21 2024, 11:22 PM
Unknown Object (File)
Sep 7 2024, 7:55 PM
Unknown Object (File)
Sep 7 2024, 4:11 PM
Subscribers

Details

Summary

TSO packets will signal segments TX completion in the separate CQ
descriptors. Each CQ descriptor for HW TSO will point to the same
SQ entry.
Do not invoke nicvf_put_sq_desc() for secondary segments to avoid
free_cnt corruption and eventually integer overflow that will result
in the negative free_cnt value and hence impossibility of further
transmission.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zbb retitled this revision from to Fix bug in VNIC causing phony number of available TX descriptors.
zbb updated this object.
zbb edited the test plan for this revision. (Show Details)
zbb added reviewers: wma, imp, andrew.
zbb set the repository for this revision to rS FreeBSD src repository - subversion.
zbb added a subscriber: arm64.
wma edited edge metadata.

Good catch!

This revision is now accepted and ready to land.Mar 3 2016, 7:04 PM
This revision was automatically updated to reflect the committed changes.