comitters-guide: Update Submitted: by trailer

[ziaee]

Summary

May require bikeshedding.

Suggested by: imp

[emaste]

It's not necessarily abandoned, this could also be used for patches submitted in non-email contexts, e.g. in a reddit comment.

Looking at some recent history I see:
Submitted by: Kraytonian -- no idea
Submitted by: markj -- maybe via comments in another review
Submitted by: MOROHOSHI Akihiko <[e-mail]> -- sounds like maybe not a patch per se, but a description of a change
Submitted by: [e-mail] -- this one looks like a missing use of git --author
Submitted by: Marco Devesas Campos <[e-mail]> -- redundant, git author also set to the same author

[markj]

In D55120#1259960, @emaste wrote:

It's not necessarily abandoned, this could also be used for patches submitted in non-email contexts, e.g. in a reddit comment.

Or changes that aren't presented with a patch at all, like inline code snippets in a phab review.

Looking at some recent history I see:
Submitted by: Kraytonian -- no idea
Submitted by: markj -- maybe via comments in another review
Submitted by: MOROHOSHI Akihiko <[e-mail]> -- sounds like maybe not a patch per se, but a description of a change
Submitted by: [e-mail] -- this one looks like a missing use of git --author
Submitted by: Marco Devesas Campos <[e-mail]> -- redundant, git author also set to the same author

[imp]

In D55120#1259993, @markj wrote:

In D55120#1259960, @emaste wrote:

It's not necessarily abandoned, this could also be used for patches submitted in non-email contexts, e.g. in a reddit comment.

Or changes that aren't presented with a patch at all, like inline code snippets in a phab review.

Looking at some recent history I see:
Submitted by: Kraytonian -- no idea
Submitted by: markj -- maybe via comments in another review
Submitted by: MOROHOSHI Akihiko <[e-mail]> -- sounds like maybe not a patch per se, but a description of a change
Submitted by: [e-mail] -- this one looks like a missing use of git --author
Submitted by: Marco Devesas Campos <[e-mail]> -- redundant, git author also set to the same author

My most common case for this for me is 'Submitted by: foo on github' when the change is trivial and not worth the round-trip to get the author name (eg a typo that's old), or that the author doesn't want to provide an email. Though many times 'Suggested by:' is better (though that requires an email or FreeBSD user id by tradition).

The main point should be that we prefer authors to include an email, require it for any non-trivial changes, and when they don't, we like to give credit anyway.

documentation/content/en/articles/committers-guide/_index.adoc

2599

Unlike the Reviewed-by: standard trailer, this tag is a comma separated list, with occasional commentary added.

Reviewed by: imp, ziaee (man pages), markj (prior version)

[ziaee]

Alright... try this!

[markj]

documentation/content/en/articles/committers-guide/_index.adoc

2593