Page MenuHomeFreeBSD
Differential D55114

sched_shim: Drop no-ifunc case
ClosedPublic
Actions

Authored by mhorne on Wed, Feb 4, 8:17 PM.

Details

Reviewers
kib
jrtc27
Commits
rG0d3652f67d24: sched_shim: Drop the no-ifunc case
Summary

Now all architectures support kernel ifunc resolvers. Therefore, the
alternate implementation can be removed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.Wed, Feb 4, 8:17 PM
Herald added subscribers: olce, imp. · View Herald TranscriptWed, Feb 4, 8:17 PM
mhorne requested review of this revision.Wed, Feb 4, 8:17 PM
Harbormaster completed remote builds in B70416: Diff 171174.Wed, Feb 4, 8:17 PM
mhorne added inline comments.Wed, Feb 4, 8:19 PM
sys/kern/sched_shim.c
25–31

I did not see a way to express this that was obviously superior to what is here now. Feel free to suggest any alternative.

mhorne mentioned this in D55082: riscv: implement kernel ifunc resolution.Wed, Feb 4, 8:20 PM
kib accepted this revision.Wed, Feb 4, 9:05 PM

I think the idea was to use VARARG, but then the types and arg names have to be split out of it. Something similar to what is done to EXTERROR() from sys/exterrvar.h and CTR() from sys/ktr.h. But it might be too convoluted for the limited use.

This revision is now accepted and ready to land.Wed, Feb 4, 9:05 PM
Closed by commit rG0d3652f67d24: sched_shim: Drop the no-ifunc case (authored by mhorne). · Explain WhyThu, Feb 5, 4:33 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG0d3652f67d24: sched_shim: Drop the no-ifunc case.

Revision Contents
Changeset List

PathSize
sys/
kern/
8 lines

Diff 171247

View Options

sys/kern/sched_shim.c

Loading...