Page MenuHomeFreeBSD

vm_phys: Check `RB_FIND()` return value in case it is NULL
ClosedPublic

Authored by dumbbell on Feb 3 2026, 12:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 6:01 PM
Unknown Object (File)
Wed, Aug 12, 12:29 PM
Unknown Object (File)
Wed, Aug 12, 9:02 AM
Unknown Object (File)
Tue, Aug 11, 5:29 PM
Unknown Object (File)
Mon, Aug 10, 12:53 PM
Unknown Object (File)
Mon, Aug 10, 8:13 AM
Unknown Object (File)
Sat, Aug 8, 10:57 AM
Unknown Object (File)
Sat, Aug 8, 2:56 AM
Subscribers

Details

Summary

When trying to unregister a fictitious range in vm_phys_fictitious_unreg_range(), the function checks the properties of the looked up segment, but it does not check if a segment was found in the first place.

This can happen with the amdgpu DRM driver which could call vm_phys_fictitious_unreg_range() without a fictitious range registered if the initialisation of the driver failed (for example because firmwares are unavailable).

The code in the DRM driver was improved to avoid that, but vm_phys_fictitious_unreg_range() should still check the return value of RB_FIND() before trying to dereference the segment pointer and panic with a page fault.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable