Page MenuHomeFreeBSD

vm_phys: Check `RB_FIND()` return value in case it is NULL
ClosedPublic

Authored by dumbbell on Feb 3 2026, 12:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 15, 5:46 AM
Unknown Object (File)
Wed, Jul 15, 5:46 AM
Unknown Object (File)
Sat, Jul 11, 2:33 PM
Unknown Object (File)
Tue, Jul 7, 7:15 PM
Unknown Object (File)
Jun 11 2026, 4:36 AM
Unknown Object (File)
May 23 2026, 3:13 AM
Unknown Object (File)
May 23 2026, 2:52 AM
Unknown Object (File)
May 22 2026, 1:40 AM
Subscribers

Details

Summary

When trying to unregister a fictitious range in vm_phys_fictitious_unreg_range(), the function checks the properties of the looked up segment, but it does not check if a segment was found in the first place.

This can happen with the amdgpu DRM driver which could call vm_phys_fictitious_unreg_range() without a fictitious range registered if the initialisation of the driver failed (for example because firmwares are unavailable).

The code in the DRM driver was improved to avoid that, but vm_phys_fictitious_unreg_range() should still check the return value of RB_FIND() before trying to dereference the segment pointer and panic with a page fault.

Sponsored by: The FreeBSD Foundation

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped