nvmecontrol: telemetry-log don't sanity check host generation number
ClosedPublic
Actions

Authored by imp on Sat, Jan 31, 7:17 PM.

Details

Reviewers

chs
chuck
mav

Commits

rGff9fe85ff245: nvmecontrol: telemetry-log don't sanity check host generation number

Summary

Don't sanity check the host initiated generation number. It's not
necessarily constant between the two log page fetches. nvme-cli doesn't
do this stanity check and it generates a lot of false positives.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Sat, Jan 31, 7:17 PM

Herald added a subscriber: dab. · View Herald TranscriptSat, Jan 31, 7:17 PM

imp requested review of this revision.Sat, Jan 31, 7:17 PM

Harbormaster completed remote builds in B70298: Diff 170899.Sat, Jan 31, 7:17 PM

imp added a parent revision: D55017: nvmecontrol: Always set the RAE bit on telemetry-log requests.Sat, Jan 31, 7:17 PM

imp added a child revision: D55019: nvmecontrol: telemetry-log --verbose.

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Feb 2, 1:32 PM

Closed by commit rGff9fe85ff245: nvmecontrol: telemetry-log don't sanity check host generation number (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGff9fe85ff245: nvmecontrol: telemetry-log don't sanity check host generation number.

Revision Contents
Changeset List

Path

Size

sbin/

nvmecontrol/

telemetry.c

10 lines

Diff 170978

View Options

sbin/nvmecontrol/telemetry.c

nvmecontrol: telemetry-log don't sanity check host generation numberClosedPublicActions