Page MenuHomeFreeBSD

Add pdrfork to OpenBSM
ClosedPublic

Authored by asomers on Mon, Jan 26, 7:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 28, 2:48 AM
Unknown Object (File)
Tue, Jan 27, 12:24 PM
Unknown Object (File)
Tue, Jan 27, 5:05 AM
Unknown Object (File)
Tue, Jan 27, 4:14 AM
Unknown Object (File)
Tue, Jan 27, 12:56 AM
Unknown Object (File)
Tue, Jan 27, 12:37 AM
Unknown Object (File)
Mon, Jan 26, 10:51 PM
Unknown Object (File)
Mon, Jan 26, 10:24 PM
Subscribers

Details

Summary

It's necessary for auditd to be able to log its events. Note that the
recently added pdwait() syscall is only auditable because an audit event
of that name was preemptively added back in 2012.

PR: 292739
MFC after: 1 week
Fixes: 5c2ee618d5e "sys: add pdrfork(2)"
Sponsored by: ConnectWise

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib added a subscriber: markj.

I think this is fine, and I have this change in some intermediate version of the patch.
But then I noted that e.g. inotify(2) is not there (unless I mistaken), so I decided that it is up to upstream to add missed syscalls, and then import a new version.
You might add inotify as well while there.

This revision is now accepted and ready to land.Mon, Jan 26, 7:28 PM
In D54897#1255061, @kib wrote:

I think this is fine, and I have this change in some intermediate version of the patch.
But then I noted that e.g. inotify(2) is not there (unless I mistaken), so I decided that it is up to upstream to add missed syscalls, and then import a new version.
You might add inotify as well while there.

Looking deeper, I've found dozens of syscalls that aren't in openbsm. membarrier, aio_writev, inotify_*, timerfd_*, and others. And there are also changes upstream that we've never merged. We have our work cut out for us ...

This revision was automatically updated to reflect the committed changes.