Page MenuHomeFreeBSD
Differential D54766

Add pthread_tryjoin_np(3) as provided by glibc
ClosedPublic
Actions

Authored by kib on Sun, Jan 18, 12:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 10, 11:33 AM
Unknown Object (File)
Sun, Feb 8, 2:45 PM
Unknown Object (File)
Sun, Feb 8, 2:40 PM
Unknown Object (File)
Sun, Feb 8, 11:31 AM
Unknown Object (File)
Sun, Feb 8, 6:39 AM
Unknown Object (File)
Sat, Feb 7, 11:29 PM
Unknown Object (File)
Mon, Feb 2, 2:17 AM
Unknown Object (File)
Sat, Jan 31, 10:03 PM
View All 34 Files
Subscribers
imp
ziaee

Details

Reviewers
emaste
markj
Commits
rG902e3057cd5c: lib/libthr: add pthread_tryjoin(3) test
rG7f026a58691d: Document pthread_tryjoin_np(3)
rGafa70a8496e9: libthr: add pthread_tryjoin_np()
rGce16be73707e: libthr/thread/thr_join.c: deduplicate backout_join() helper
Summary
libthr/thread/thr_join.c: deduplicate backout_join() helper


libthr: add pthread_tryjoin_np()

Similar to the same glibc function.


Document pthread_tryjoin_np(3)


lib/libthr: add pthread_tryjoin(3) test

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Sun, Jan 18, 12:56 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptSun, Jan 18, 12:56 PM
kib requested review of this revision.Sun, Jan 18, 12:56 PM
kib updated this revision to Diff 169999.Sun, Jan 18, 1:12 PM

Convert test to the proper atf, instead of using err()

kib updated this revision to Diff 170008.Sun, Jan 18, 3:03 PM

After a second thought, the pthread_tryjoin_np(3) function must be non-cancelling.

markj added inline comments.Mon, Jan 19, 3:02 PM
lib/libthr/thread/thr_join.c
100

Why not just lock pthread in the caller? There is only one caller that passes thr_locked=false.

share/man/man3/pthread_join.3
112 ↗(On Diff #170008)
113 ↗(On Diff #170008)
114 ↗(On Diff #170008)
kib updated this revision to Diff 170046.Mon, Jan 19, 3:55 PM
kib marked 4 inline comments as done.

Handle review' comments.

markj accepted this revision.Mon, Jan 19, 4:48 PM
This revision is now accepted and ready to land.Mon, Jan 19, 4:48 PM
Closed by commit rGce16be73707e: libthr/thread/thr_join.c: deduplicate backout_join() helper (authored by kib). · Explain WhyMon, Jan 19, 4:58 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGce16be73707e: libthr/thread/thr_join.c: deduplicate backout_join() helper.
kib added a commit: rGafa70a8496e9: libthr: add pthread_tryjoin_np().
kib added a commit: rG7f026a58691d: Document pthread_tryjoin_np(3).
kib added a commit: rG902e3057cd5c: lib/libthr: add pthread_tryjoin(3) test.

Revision Contents
Changeset List

PathSize
lib/
libthr/
thread/
21 lines

Diff 170059

View Options

lib/libthr/thread/thr_join.c

Loading...