Page MenuHomeFreeBSD

Add pthread_tryjoin_np(3) as provided by glibc
Needs ReviewPublic

Authored by kib on Sun, Jan 18, 12:56 PM.
Tags
None
Referenced Files
F142395665: D54766.id169999.diff
Mon, Jan 19, 1:37 PM
F142361181: D54766.id169996.diff
Mon, Jan 19, 1:58 AM
F142357792: D54766.id169996.diff
Mon, Jan 19, 12:41 AM
F142356390: D54766.diff
Mon, Jan 19, 12:11 AM
F142350270: D54766.id170008.diff
Sun, Jan 18, 10:07 PM
F142347619: D54766.id.diff
Sun, Jan 18, 9:19 PM
F142346321: D54766.id169999.diff
Sun, Jan 18, 8:54 PM
F142345997: D54766.id170008.diff
Sun, Jan 18, 8:49 PM
Subscribers

Details

Reviewers
emaste
markj
Summary
libthr/thread/thr_join.c: deduplicate backout_join() helper


libthr: add pthread_tryjoin_np()

Similar to the same glibc function.


Document pthread_tryjoin_np(3)


lib/libthr: add pthread_tryjoin(3) test

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib requested review of this revision.Sun, Jan 18, 12:56 PM

Convert test to the proper atf, instead of using err()

After a second thought, the pthread_tryjoin_np(3) function must be non-cancelling.

lib/libthr/thread/thr_join.c
103

Why not just lock pthread in the caller? There is only one caller that passes thr_locked=false.

share/man/man3/pthread_join.3
112
113
114
kib marked 4 inline comments as done.

Handle review' comments.