Page MenuHomeFreeBSD

smartpqi: Avoid declaring extern inline functions
ClosedPublic

Authored by markj on Jan 15 2026, 5:03 PM.
Tags
None
Referenced Files
F168321186: D54732.id.diff
Thu, Aug 27, 3:01 PM
F168232636: D54732.id169827.diff
Thu, Aug 27, 2:10 AM
Unknown Object (File)
Wed, Aug 26, 8:27 AM
Unknown Object (File)
Tue, Aug 25, 10:21 AM
Unknown Object (File)
Tue, Aug 25, 12:55 AM
Unknown Object (File)
Sun, Aug 23, 10:57 AM
Unknown Object (File)
Sat, Aug 22, 6:52 AM
Unknown Object (File)
Fri, Aug 21, 12:45 PM
Subscribers
None

Details

Summary

Each C file is compiled separately so these functions can't be inlined
except in the file where they are defined. Since these functions aren't
used outside smartpqi_request.c, just do the simple thing and make them
private to that file.

Alternately, we can drop the inline annotation.

Reported by: gcc

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Jan 15 2026, 5:03 PM
markj created this revision.
sys/dev/smartpqi/smartpqi_request.c
1495

imp@ actually had an older patch that I missed and actually overwrote in 2f06449d64298fe508e3c585b45effd69a72d696 in which he made this just static.

1639

imp@ actually had an older patch that I missed and actually overwrote in 2f06449d64298fe508e3c585b45effd69a72d696 in which he made this just static.

Yea. inline often isn't needed these days...

sys/dev/smartpqi/smartpqi_request.c
1639

I Came here to say that :)

This revision is now accepted and ready to land.Jan 16 2026, 4:21 PM