Page MenuHomeFreeBSD

smartpqi: Avoid declaring extern inline functions
ClosedPublic

Authored by markj on Jan 15 2026, 5:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 16, 12:18 PM
Unknown Object (File)
Thu, Sep 10, 7:58 PM
Unknown Object (File)
Mon, Sep 7, 5:36 AM
Unknown Object (File)
Sun, Sep 6, 3:08 PM
Unknown Object (File)
Sun, Sep 6, 6:26 AM
Unknown Object (File)
Sat, Sep 5, 7:37 PM
Unknown Object (File)
Sat, Sep 5, 9:18 AM
Unknown Object (File)
Fri, Sep 4, 12:44 PM
Subscribers
None

Details

Summary

Each C file is compiled separately so these functions can't be inlined
except in the file where they are defined. Since these functions aren't
used outside smartpqi_request.c, just do the simple thing and make them
private to that file.

Alternately, we can drop the inline annotation.

Reported by: gcc

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Jan 15 2026, 5:03 PM
markj created this revision.
sys/dev/smartpqi/smartpqi_request.c
1495

imp@ actually had an older patch that I missed and actually overwrote in 2f06449d64298fe508e3c585b45effd69a72d696 in which he made this just static.

1639

imp@ actually had an older patch that I missed and actually overwrote in 2f06449d64298fe508e3c585b45effd69a72d696 in which he made this just static.

Yea. inline often isn't needed these days...

sys/dev/smartpqi/smartpqi_request.c
1639

I Came here to say that :)

This revision is now accepted and ready to land.Jan 16 2026, 4:21 PM