Page MenuHomeFreeBSD
Differential D54701

termios.4: Cross-reference stack(9) for the STATUS character
ClosedPublic
Actions

Authored by tembun_bk.ru on Wed, Jan 14, 10:13 AM.
Tags
Referenced Files
Unknown Object (File)
Fri, Jan 16, 12:06 AM
Unknown Object (File)
Thu, Jan 15, 11:54 PM
Unknown Object (File)
Thu, Jan 15, 10:05 PM
Unknown Object (File)
Thu, Jan 15, 9:44 PM
Unknown Object (File)
Thu, Jan 15, 8:11 PM
Unknown Object (File)
Thu, Jan 15, 7:41 PM
Unknown Object (File)
Thu, Jan 15, 6:56 PM
Unknown Object (File)
Thu, Jan 15, 10:03 AM
View All 11 Files
Subscribers
imp

Details

Reviewers
ziaee
kib
Group Reviewers
docs
manpages
Commits
rGfd34f549b711: termios.4: Cross-reference stack(9) for STATUS
Summary

If kernel is built without stack(9) (options STACK), then mentioned sysctl(8) kern.tty_info_kstacks will not be found.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tembun_bk.ru created this revision.Wed, Jan 14, 10:13 AM
Herald added a subscriber: imp. · View Herald TranscriptWed, Jan 14, 10:13 AM
tembun_bk.ru requested review of this revision.Wed, Jan 14, 10:13 AM
kib added a comment.Wed, Jan 14, 4:00 PM

You need to explain what you put into the summary, in the man page itself. Otherwise the reference to stack(9) looks out of context.

tembun_bk.ru updated this revision to Diff 169712.Wed, Jan 14, 4:46 PM

Better integrate stack(9) reference into the sentence.

kib added inline comments.Wed, Jan 14, 4:56 PM
share/man/man4/termios.4
764
tembun_bk.ru updated this revision to Diff 169714.Wed, Jan 14, 5:03 PM

Fix the wording (suggested by kib).

kib accepted this revision.Wed, Jan 14, 5:16 PM
This revision is now accepted and ready to land.Wed, Jan 14, 5:16 PM
ziaee added inline comments.Wed, Jan 14, 5:28 PM
share/man/man4/termios.4
28

This will cause a linter error

tembun_bk.ru updated this revision to Diff 169732.Wed, Jan 14, 6:38 PM

s/Jan/January/ in .Dd.

This revision now requires review to proceed.Wed, Jan 14, 6:38 PM
tembun_bk.ru marked an inline comment as done.Wed, Jan 14, 6:38 PM
tembun_bk.ru added a comment.Thu, Jan 15, 2:35 PM

Ping @ziaee?

ziaee accepted this revision.Thu, Jan 15, 4:42 PM

Thanks for the ping! I get busy and forget about stuff so I really appreciate pings!

This revision is now accepted and ready to land.Thu, Jan 15, 4:42 PM
ziaee added a comment.Fri, Jan 16, 8:26 PM

This is such a beautifully structured manual. People often abuse .Sh when really they should be subsections of DESCRIPTION. Thanks for the patch Artem!

Closed by commit rGfd34f549b711: termios.4: Cross-reference stack(9) for STATUS (authored by tembun_bk.ru, committed by ziaee). · Explain WhyFri, Jan 16, 8:27 PM
This revision was automatically updated to reflect the committed changes.
ziaee added a commit: rGfd34f549b711: termios.4: Cross-reference stack(9) for STATUS.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
6 lines

Diff 169910

View Options

share/man/man4/termios.4

Loading...