Page MenuHomeFreeBSD
Differential D54699

tdestroy: don't visit one-child node twice
Needs ReviewPublic
Actions

Authored by dougm on Wed, Jan 14, 6:06 AM.

Details

Reviewers
alc
kib
Summary

Change tdestroy() to immediately free a node with no right child as soon as it is encountered. Currently, such nodes are visited twice before deletion.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm requested review of this revision.Wed, Jan 14, 6:06 AM
dougm created this revision.
dougm updated this revision to Diff 169672.Wed, Jan 14, 7:26 AM

Remove a redundant NULL check.

kib added a comment.Wed, Jan 14, 5:04 PM

Did you tested this with lib/libc/tests/stdlib/tsearch_test.c?
If it works, I am fine with it.

Revision Contents
Changeset List

PathSize
lib/
libc/
stdlib/
66 lines

Diff 169672

View Options

lib/libc/stdlib/tdestroy.c

Loading...