Page MenuHomeFreeBSD
Differential D54675

libexecinfo: tests: Expect failure on aarch64
ClosedPublic
Actions

Authored by jlduran on Mon, Jan 12, 8:57 PM.
Tags
None
Referenced Files
F141964032: D54675.id169541.diff
Wed, Jan 14, 6:21 AM
Unknown Object (File)
Tue, Jan 13, 1:39 PM
Subscribers
arichardson
imp

Details

Reviewers
dchagin
emaste
guest-svmhdvn
Group Reviewers
tests
Commits
rGfef84fd8ae84: libexecinfo: tests: Expect failure on aarch64
Summary

Add a guard that expects a failure of the test on aarch64.

Fixes: df1ea5887326 ("tests: Test libexecinfo backtrace call througth signal trampoline")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jlduran created this revision.Mon, Jan 12, 8:57 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Jan 12, 8:57 PM
jlduran requested review of this revision.Mon, Jan 12, 8:57 PM
jlduran added reviewers: tests, dchagin, emaste.Mon, Jan 12, 8:58 PM
jlduran added a comment.Mon, Jan 12, 9:02 PM

Reference: https://ci.freebsd.org/view/Test/job/FreeBSD-main-aarch64-test/1040/testReport/junit/lib.libexecinfo/sigtramp_test/test_backtrace_sigtramp/

jlduran updated this revision to Diff 169571.Tue, Jan 13, 5:52 PM
jlduran retitled this revision from libexecinfo: tests: Skip on aarch64 to libexecinfo: tests: Expect failure on aarch64.
jlduran edited the summary of this revision. (Show Details)
  • Do not skip, but expect fail
  • Terse message
Harbormaster completed remote builds in B69835: Diff 169541.Wed, Jan 14, 12:50 AM
jlduran added a reviewer: guest-svmhdvn.Wed, Jan 14, 2:20 PM
emaste accepted this revision.Wed, Jan 14, 2:48 PM
emaste added a subscriber: arichardson.

I think it's worth adding a comment as well -- https://reviews.llvm.org is deprecated and this review is never going to be updated or completed. I'm not sure if @dchagin or @arichardson have a rebased version of it but someone will need to pick it up.

But adding the xfail is certainly good.

This revision is now accepted and ready to land.Wed, Jan 14, 2:48 PM
jlduran added a comment.Wed, Jan 14, 4:48 PM

I'll add the comment upon commit:

/* https://reviews.llvm.org is deprecated and this review is never going to be updated or completed */

Thanks.

Closed by commit rGfef84fd8ae84: libexecinfo: tests: Expect failure on aarch64 (authored by jlduran). · Explain WhyWed, Jan 14, 5:08 PM
This revision was automatically updated to reflect the committed changes.
jlduran added a commit: rGfef84fd8ae84: libexecinfo: tests: Expect failure on aarch64.

Revision Contents
Changeset List

PathSize
lib/
libexecinfo/
tests/
8 lines

Diff 169716

View Options

lib/libexecinfo/tests/sigtramp_test.c

Loading...