Allwinner A31/A31s USB support

[jmcneill]

Summary

This change adds support to the a10_ehci.c driver for A31/A31s and the necessary clock setup.

[manu_bidouilliste.com]

sys/arm/allwinner/a10_ehci.c

236 ↗

(On Diff #13809)

You can use ofw_bus_search_compatible with different ocd_data instead.

[jmcneill_invisible.ca]

sys/arm/allwinner/a10_ehci.c

236 ↗

(On Diff #13809)

Good idea, I'll do that

[jmcneill_invisible.ca]

• Removed hard-coded GPIO pin numbers from a10_ehci.c
• Added new awusbphy driver to handle GPIO pin settings from FDT
• Use compat data to handle differences between SoC families
• Add A31 USB clock deactivate function

[manu_bidouilliste.com]

Should we rename now a10_ehci.c to aw_ehci.c ?
And start doing incremental renaming file for when we change the drivers ?

[jmcneill_invisible.ca]

In D5467#116566, @manu_bidouilliste.com wrote:

Should we rename now a10_ehci.c to aw_ehci.c ?
And start doing incremental renaming file for when we change the drivers ?

I think I'd rather rename it after. I'd have to rename all of the functions and #defines, and I don't really want to mix that up with functional changes.

[jmcneill_invisible.ca]

• Use GPIO_MAP_GPIOS to find pin number.

[manu_bidouilliste.com]

USB now works for me on A10, A20 and A31S.

[jmcneill_invisible.ca]

• Only activate EHCI and required PHY clocks, not OHCI or USB DRD.
• Add EHCI clock ref count and only deactivate EHCI clocks when there are no users.
• Rename a31_clk_usb_activate/deactivate to a31_clk_ehci_activate/deactivate.

[andrew]

sys/arm/allwinner/a31/a31_clk.c

308 ↗

(On Diff #13847)

What about if two CPUs both called this function at the same time? One would enable the clock, but the other would assume the clock is already enabled then start to use the hardware.

345 ↗

(On Diff #13847)

What about if one CPU calls this, then while this is being run another CPU calls the activate code? We could have two CPUs both trying to access the registers, one to disable, the other to enable.

[jmcneill_invisible.ca]

sys/arm/allwinner/a31/a31_clk.c

308 ↗

(On Diff #13847)

Good point, I will replace this with a lock.

[jmcneill_invisible.ca]

Protect EHCI clock reference counter with a lock.

[andrew]

sys/arm/allwinner/a10_ehci.c

79 ↗

(On Diff #13848)

ocd_data is already uintptr_t, there should be no need for that cast.

[jmcneill]

Remove redundant cast of ocd_data to uintptr_t