Details

Reviewers

bz
imp
marius

Group Reviewers

Contributor Reviews (src)

Summary

This adds and fixes values defined in the latest SD and eMMC standard. This is a breaking change, but it has to happen because FreeBSD's mmc macro doesn't match the spec's field name, which could be painful for device driver developers.

This is part of effort to bring mmc support for linuxkpi. Linux doesn't follow standard field name in some cases like DEVICE_TYPE, but it could be fixed in linux/mmc/mmc.h

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 69732
Build 66615: arc lint + arc unit

Event Timeline

minsoochoo0122_proton.me created this revision.Thu, Jan 8, 5:28 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Jan 8, 5:28 PM

minsoochoo0122_proton.me requested review of this revision.Thu, Jan 8, 5:28 PM

Harbormaster completed remote builds in B69724: Diff 169335.Thu, Jan 8, 5:28 PM

minsoochoo0122_proton.me edited the summary of this revision. (Show Details)Thu, Jan 8, 5:29 PM

minsoochoo0122_proton.me added a reviewer: Contributor Reviews (src).

minsoochoo0122_proton.me added a project: Contributor Reviews (src).

Align comment

Harbormaster completed remote builds in B69725: Diff 169336.Thu, Jan 8, 5:31 PM

This change could be controversial: both keeping old name and strictly following the spec's name makes sense. Even Linux doesn't strictly follow spec's field name such as PARTITION (PART) and DEVICE ('CARD`), so handling these cases in linuxkpi header is inevitable either way. I want to hear others' opinion on this.

emaste added a reviewer: bz.Thu, Jan 8, 5:53 PM

emaste added a reviewer: imp.

Partial build fix

Harbormaster completed remote builds in B69730: Diff 169341.Thu, Jan 8, 7:23 PM

As this moves MMC 3.31 to eMMC 5.1, we need to discuss backward-compatibility issue.

fix missing stuff

Harbormaster completed remote builds in B69731: Diff 169342.Thu, Jan 8, 7:28 PM

stick with mmc for now

Harbormaster completed remote builds in B69732: Diff 169343.Thu, Jan 8, 8:15 PM

minsoochoo0122_proton.me added a reviewer: marius.Thu, Jan 8, 8:24 PM