sesutil: Remove width limiter on encoded "Desc" field
ClosedPublic
Actions

Authored by js on Mon, Jan 5, 7:39 PM.

Details

Reviewers

asomers
bapt
phk

Commits

rGbf98d6775d7f: sesutil: Remove width modifier on encoded "Desc" field

Summary

Remove the width modifiers on the encoded output as libxo appends white spaces to it to match width.

Before:

"description": "Slot 00        ",

After:

"description": "Slot 00",

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

js created this revision.Mon, Jan 5, 7:39 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jan 5, 7:39 PM

js requested review of this revision.Mon, Jan 5, 7:39 PM

js added a reviewer: bapt.Mon, Jan 5, 7:45 PM

js added a reviewer: phk.

I can't reproduce this behavior with "sesutil map --libxo=json,pretty". What is the right way to trigger the bug?

In D54536#1245936, @asomers wrote:

I can't reproduce this behavior with "sesutil map --libxo=json,pretty". What is the right way to trigger the bug?

It's only the show command, try sesutil --libxo:JP show instead.

LGTM. But you should wrap the long line in your commit message . And add something to the commit message indicating that the problem is with the "show" subcommand.

This revision is now accepted and ready to land.Mon, Jan 5, 8:18 PM

Closed by commit rGbf98d6775d7f: sesutil: Remove width modifier on encoded "Desc" field (authored by js). · Explain WhyThu, Jan 8, 4:17 PM

This revision was automatically updated to reflect the committed changes.

js added a commit: rGbf98d6775d7f: sesutil: Remove width modifier on encoded "Desc" field.

Revision Contents
Changeset List

Path

Size

usr.sbin/

sesutil/

sesutil.c

2 lines

Diff 169327

View Options

usr.sbin/sesutil/sesutil.c

sesutil: Remove width limiter on encoded "Desc" fieldClosedPublicActions