Page MenuHomeFreeBSD
Differential D54494

linuxkpi: Replicate the chain of #include in the `cec*.h` headers
ClosedPublic
Actions

Authored by dumbbell on Sun, Jan 4, 10:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 13, 7:55 AM
Unknown Object (File)
Mon, Jan 12, 11:23 PM
Unknown Object (File)
Fri, Jan 9, 2:35 AM
Unknown Object (File)
Fri, Jan 9, 2:06 AM
Unknown Object (File)
Thu, Jan 8, 10:27 PM
Unknown Object (File)
Wed, Jan 7, 12:34 AM
Unknown Object (File)
Tue, Jan 6, 9:43 PM
Unknown Object (File)
Tue, Jan 6, 5:47 PM
View All 12 Files
Subscribers
bz
emaste
imp

Details

Reviewers
bz
christos
Group Reviewers
linuxkpi
Commits
rG10c6f1f627cd: linuxkpi: Replicate the chain of #include in the `cec*.h` headers
Summary

The i915 DRM driver depends on this namespace pollution to access debugfs_* functions, after several explicit #include of <linux/debugfs.h> were removed in Linux 6.10.

This is part of the update of DRM drivers to Linux 6.10.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dumbbell created this revision.Sun, Jan 4, 10:24 AM
Herald added subscribers: emaste, imp. · View Herald TranscriptSun, Jan 4, 10:24 AM
dumbbell requested review of this revision.Sun, Jan 4, 10:24 AM
bz requested changes to this revision.Sun, Jan 4, 9:10 PM
bz added a subscriber: bz.

For all the files.

Otherwise seems fine.

sys/compat/linuxkpi/common/include/linux/cec-funcs.h
2

Not needed anymore

9

Use SPDX?

37

no defined()

This revision now requires changes to proceed.Sun, Jan 4, 9:10 PM
dumbbell updated this revision to Diff 169123.Mon, Jan 5, 8:25 PM
dumbbell marked 3 inline comments as done.

Address comments from @bz.

bz accepted this revision.Tue, Jan 6, 12:13 AM
This revision is now accepted and ready to land.Tue, Jan 6, 12:13 AM
christos accepted this revision.Tue, Jan 6, 11:10 AM
Closed by commit rG10c6f1f627cd: linuxkpi: Replicate the chain of #include in the `cec*.h` headers (authored by dumbbell). · Explain WhyWed, Jan 7, 9:51 PM
This revision was automatically updated to reflect the committed changes.
dumbbell added a commit: rG10c6f1f627cd: linuxkpi: Replicate the chain of #include in the `cec*.h` headers.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
16 lines
3 lines
media/
17 lines
23 lines
dummy/
include/
media/

Diff 169280

View Options

sys/compat/linuxkpi/common/include/linux/cec-funcs.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/cec.h

Loading...
View Options

sys/compat/linuxkpi/common/include/media/cec-notifier.h

Loading...
View Options

sys/compat/linuxkpi/common/include/media/cec.h

Loading...
View Options

sys/compat/linuxkpi/dummy/include/media/cec-notifier.h

Loading...