Page MenuHomeFreeBSD
Differential D54493

linuxkpi: Add WARN_RATELIMIT()
ClosedPublic
Actions

Authored by dumbbell on Sun, Jan 4, 10:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 9, 2:06 AM
Unknown Object (File)
Thu, Jan 8, 10:14 PM
Unknown Object (File)
Wed, Jan 7, 12:20 PM
Unknown Object (File)
Tue, Jan 6, 1:50 PM
Unknown Object (File)
Mon, Jan 5, 12:11 PM
Unknown Object (File)
Mon, Jan 5, 8:30 AM
Unknown Object (File)
Mon, Jan 5, 8:10 AM
Unknown Object (File)
Mon, Jan 5, 2:48 AM
View All 11 Files
Subscribers
bz
emaste
imp

Details

Reviewers
bz
christos
Group Reviewers
linuxkpi
Commits
rG3942e85b9921: linuxkpi: Add WARN_RATELIMIT()
Summary

The i915 DRM driver started to use it in Linux 6.10.

This is part of the update of DRM drivers to Linux 6.10.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dumbbell created this revision.Sun, Jan 4, 10:23 AM
Herald added subscribers: emaste, imp. · View Herald TranscriptSun, Jan 4, 10:23 AM
dumbbell requested review of this revision.Sun, Jan 4, 10:23 AM
bz requested changes to this revision.Sun, Jan 4, 9:08 PM
bz added a subscriber: bz.
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/kernel.h
262 ↗(On Diff #169002)

This feels like it belongs into ratelimit.h. If not then it could be implemented ratelimiting. We do have pr_warn_ratelimited()

This revision now requires changes to proceed.Sun, Jan 4, 9:08 PM
dumbbell marked an inline comment as done.Mon, Jan 5, 8:24 PM
dumbbell added inline comments.
sys/compat/linuxkpi/common/include/linux/kernel.h
262 ↗(On Diff #169002)

You are right, this was the wrong header. This is now fixed.

I also used pr_warn_ratelimited().

dumbbell updated this revision to Diff 169122.Mon, Jan 5, 8:25 PM
dumbbell marked an inline comment as done.
dumbbell retitled this revision from linuxkpi: Define WARN_RATELIMIT() as a synonym to WARN() to linuxkpi: Add WARN_RATELIMIT().
bz accepted this revision.Tue, Jan 6, 12:12 AM
This revision is now accepted and ready to land.Tue, Jan 6, 12:12 AM
christos accepted this revision.Tue, Jan 6, 11:09 AM
Closed by commit rG3942e85b9921: linuxkpi: Add WARN_RATELIMIT() (authored by dumbbell). · Explain WhyWed, Jan 7, 9:51 PM
This revision was automatically updated to reflect the committed changes.
dumbbell added a commit: rG3942e85b9921: linuxkpi: Add WARN_RATELIMIT().

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
7 lines

Diff 169279

View Options

sys/compat/linuxkpi/common/include/linux/ratelimit.h

Loading...