Page MenuHomeFreeBSD

linuxkpi: Add <linux/font.h>
ClosedPublic

Authored by dumbbell on Sun, Jan 4, 10:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 14, 5:40 AM
Unknown Object (File)
Sat, Jan 10, 3:33 PM
Unknown Object (File)
Fri, Jan 9, 2:02 PM
Unknown Object (File)
Fri, Jan 9, 2:06 AM
Unknown Object (File)
Fri, Jan 9, 12:48 AM
Unknown Object (File)
Thu, Jan 8, 10:37 PM
Unknown Object (File)
Thu, Jan 8, 9:47 PM
Unknown Object (File)
Thu, Jan 8, 11:30 AM
Subscribers

Details

Summary

The header defines the minimum to allow the DRM generic code to build. The only function used so far is get_default_font(), as part of a DRM-specific panic handler. We do not use this panic handler on FreeBSD.

For now, it returns a NULL value. It should probably map to a vt(4) font.

The DRM generic code started to use it in Linux 6.10 as part of the panic handler.

This is part of the update of DRM drivers to Linux 6.10.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested changes to this revision.Sun, Jan 4, 9:01 PM
bz added a subscriber: bz.
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/font.h
2
  • is not needed anymore
9

You could use the SPDX tag here?

40

Can we split these into two lines please?

42

Unless order is very specific in the struct this is sillily ordered. I would probably put the *name before the *data but then the question is what is normally accessed more often? It may make sense to put the *data pointer up first; but at least keep 2/4 ints together?

53

remove defined()

This revision now requires changes to proceed.Sun, Jan 4, 9:01 PM
dumbbell added inline comments.
sys/compat/linuxkpi/common/include/linux/font.h
42

I moved the name and data to the beginning. It was just the same order as Linux, but that’s ok to change it.

dumbbell marked an inline comment as done.

Address comments from @bz.

bz added inline comments.
sys/compat/linuxkpi/common/include/linux/font.h
2

According to style.9 the SPDX-Tag goes below the copyrights; just for the future.

The copyright header should be a multi-line comment like so:

/*
 * Copyright (c) 1984-2025 John Q. Public
 *
 * SPDX-License-Identifier: BSD-2-Clause
 */
This revision is now accepted and ready to land.Tue, Jan 6, 12:08 AM
This revision was automatically updated to reflect the committed changes.