Page MenuHomeFreeBSD
Differential D54398

Make .align match comment in code
Needs ReviewPublic
Actions

Authored by cperciva on Dec 29 2025, 5:12 PM.
Tags
None
Referenced Files
F150921319: D54398.diff
Sat, Apr 4, 11:27 PM
Unknown Object (File)
Mar 5 2026, 8:44 PM
Unknown Object (File)
Jan 16 2026, 11:51 AM
Unknown Object (File)
Jan 9 2026, 10:12 PM
Unknown Object (File)
Jan 8 2026, 10:08 AM
Unknown Object (File)
Jan 7 2026, 7:10 PM
Unknown Object (File)
Jan 7 2026, 4:45 PM
Unknown Object (File)
Jan 7 2026, 2:20 AM
View All 14 Files
Subscribers
emaste
imp

Details

Reviewers
andrew
manu
Summary

I have no idea whether the comment is wrong or the .align is wrong. Also, no idea if this can cause any problems; it just caught my eye as I was looking at the code.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

cperciva created this revision.Dec 29 2025, 5:12 PM
Herald added a reviewer: manu. · View Herald TranscriptDec 29 2025, 5:12 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
cperciva requested review of this revision.Dec 29 2025, 5:12 PM
andrew added inline comments.Dec 29 2025, 5:15 PM
sys/arm64/arm64/sigtramp.S
51–52

This and the comment should be removed, this isn't copied to the stack as we use the shared page, and the stack is non-executable.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
2 lines

Diff 168713

View Options

sys/arm64/arm64/sigtramp.S

Loading...