Page MenuHomeFreeBSD

crypto: avoid warnings about too-long initializer strings
ClosedPublic

Authored by dim on Dec 26 2025, 12:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 3, 11:45 PM
Unknown Object (File)
Fri, Apr 3, 9:25 PM
Unknown Object (File)
Wed, Apr 1, 5:51 AM
Unknown Object (File)
Wed, Apr 1, 5:15 AM
Unknown Object (File)
Fri, Mar 20, 1:31 AM
Unknown Object (File)
Tue, Mar 17, 5:16 PM
Unknown Object (File)
Tue, Mar 17, 1:24 AM
Unknown Object (File)
Fri, Mar 13, 10:56 PM
Subscribers

Details

Summary

Mark sigma and tau as __non_string, to avoid warnings from
clang 21 similar to:

sys/crypto/chacha20/chacha.c:53:31: error: initializer-string for character array is too long, array size is 16 but initializer has size 17 (including the null terminating character); did you mean to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization]
   53 | static const char sigma[16] = "expand 32-byte k";
      |                               ^~~~~~~~~~~~~~~~~~
sys/crypto/chacha20/chacha.c:54:29: error: initializer-string for character array is too long, array size is 16 but initializer has size 17 (including the null terminating character); did you mean to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization]
   54 | static const char tau[16] = "expand 16-byte k";
      |                             ^~~~~~~~~~~~~~~~~~

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dim requested review of this revision.Dec 26 2025, 12:14 AM

Fix double word in commit message.

This revision is now accepted and ready to land.Dec 29 2025, 2:37 PM