Differential D54340

bhyve: Use a blocking socket in the helper process
ClosedPublic
Actions

Authored by markj on Dec 22 2025, 7:15 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 12, 8:58 AM

	Unknown Object (File)
	Thu, Sep 10, 2:08 PM

	Unknown Object (File)
	Thu, Sep 10, 8:15 AM

	Unknown Object (File)
	Mon, Sep 7, 9:26 AM

	Unknown Object (File)
	Mon, Sep 7, 9:07 AM

	Unknown Object (File)
	Mon, Sep 7, 3:52 AM

	Unknown Object (File)
	Sat, Sep 5, 4:53 PM

	Unknown Object (File)
	Sat, Sep 5, 12:10 PM

View All 90 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG777f67d8a9c3: bhyve: Use a blocking socket in the helper process
rGdaef625cf884: bhyve: Use a blocking socket in the helper process

Summary

The send_packet callback does not handle EAGAIN, and on the recv side we
already use poll() and MSG_DONTWAIT to implement a non-blocking loop.

PR: 291616

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Dec 22 2025, 7:15 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptDec 22 2025, 7:15 PM

markj requested review of this revision.Dec 22 2025, 7:15 PM

Harbormaster completed remote builds in B69442: Diff 168527.Dec 22 2025, 7:16 PM

novel added a subscriber: novel.Dec 24 2025, 5:21 PM

novel accepted this revision.Dec 24 2025, 5:29 PM

This revision is now accepted and ready to land.Dec 24 2025, 5:29 PM

Closed by commit rGdaef625cf884: bhyve: Use a blocking socket in the helper process (authored by markj). · Explain WhyDec 29 2025, 2:50 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGdaef625cf884: bhyve: Use a blocking socket in the helper process.

markj added a commit: rG777f67d8a9c3: bhyve: Use a blocking socket in the helper process.Jun 25 2026, 5:25 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

slirp/

2 lines

Diff 168702

usr.sbin/bhyve/slirp/slirp-helper.c

Loading...