Differential D54340

bhyve: Use a blocking socket in the helper process
ClosedPublic
Actions

Authored by markj on Mon, Dec 22, 7:15 PM.

Details

Reviewers

novel

Group Reviewers

bhyve

Commits

rGdaef625cf884: bhyve: Use a blocking socket in the helper process

Summary

The send_packet callback does not handle EAGAIN, and on the recv side we
already use poll() and MSG_DONTWAIT to implement a non-blocking loop.

PR: 291616

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mon, Dec 22, 7:15 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMon, Dec 22, 7:15 PM

markj requested review of this revision.Mon, Dec 22, 7:15 PM

Harbormaster completed remote builds in B69442: Diff 168527.Mon, Dec 22, 7:16 PM

novel added a subscriber: novel.Wed, Dec 24, 5:21 PM

novel accepted this revision.Wed, Dec 24, 5:29 PM

This revision is now accepted and ready to land.Wed, Dec 24, 5:29 PM

Closed by commit rGdaef625cf884: bhyve: Use a blocking socket in the helper process (authored by markj). · Explain WhyMon, Dec 29, 2:50 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGdaef625cf884: bhyve: Use a blocking socket in the helper process.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

slirp/

slirp-helper.c

2 lines

Diff 168702

View Options

usr.sbin/bhyve/slirp/slirp-helper.c

bhyve: Use a blocking socket in the helper processClosedPublicActions