Differential D54290

telnet: Remove usage of ALIGN
ClosedPublic
Actions

Authored by markj on Dec 18 2025, 5:50 PM.

Details

Reviewers

brooks

Commits

rGeb92fbcadeec: telnet: Remove usage of ALIGN
rG3a4275a5f1f5: telnet: Remove usage of ALIGN

Summary

gcc doesn't like ALIGN() being applied to an array type. Just use
__aligned instead.

Fixes: 80203a27e964 ("Add sys/_align.h replacing machine/_align.h")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Dec 18 2025, 5:50 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 18 2025, 5:50 PM

markj requested review of this revision.Dec 18 2025, 5:50 PM

Harbormaster completed remote builds in B69375: Diff 168331.Dec 18 2025, 5:50 PM

brooks accepted this revision.Mon, Dec 22, 10:10 AM

brooks added inline comments.

contrib/telnet/telnet/commands.c
2851	At least I think the XXX is probably referring to the evil use of ALIGN?

This revision is now accepted and ready to land.Mon, Dec 22, 10:10 AM

markj added inline comments.Mon, Dec 22, 3:18 PM

contrib/telnet/telnet/commands.c
2851	I had thought so too, but it predates it, see commit c847fdb1f93a7.

Closed by commit rG3a4275a5f1f5: telnet: Remove usage of ALIGN (authored by markj). · Explain WhyMon, Dec 22, 3:51 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG3a4275a5f1f5: telnet: Remove usage of ALIGN.

markj added a commit: rGeb92fbcadeec: telnet: Remove usage of ALIGN.Mon, Dec 29, 5:07 PM

Revision Contents
Changeset List

Path

Size

contrib/

telnet/

commands.c

4 lines

Diff 168520

View Options

contrib/telnet/telnet/commands.c

telnet: Remove usage of ALIGNClosedPublicActions