Page MenuHomeFreeBSD
Differential D54290

telnet: Remove usage of ALIGN
ClosedPublic
Actions

Authored by markj on Dec 18 2025, 5:50 PM.
Tags
None
Referenced Files
F162625951: D54290.diff
Wed, Jul 15, 5:42 AM
F162625950: D54290.diff
Wed, Jul 15, 5:42 AM
Unknown Object (File)
Thu, Jul 9, 3:07 AM
Unknown Object (File)
Wed, Jul 8, 7:58 PM
Unknown Object (File)
Wed, Jul 8, 5:27 AM
Unknown Object (File)
Mon, Jul 6, 1:03 PM
Unknown Object (File)
Sat, Jul 4, 6:15 AM
Unknown Object (File)
Sat, Jul 4, 6:12 AM
View All 47 Files
Subscribers
imp

Details

Reviewers
brooks
Commits
rGeb92fbcadeec: telnet: Remove usage of ALIGN
rG3a4275a5f1f5: telnet: Remove usage of ALIGN
Summary

gcc doesn't like ALIGN() being applied to an array type. Just use
__aligned instead.

Fixes: 80203a27e964 ("Add sys/_align.h replacing machine/_align.h")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Dec 18 2025, 5:50 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 18 2025, 5:50 PM
markj requested review of this revision.Dec 18 2025, 5:50 PM
Harbormaster completed remote builds in B69375: Diff 168331.Dec 18 2025, 5:50 PM
brooks accepted this revision.Dec 22 2025, 10:10 AM
brooks added inline comments.
contrib/telnet/telnet/commands.c
2851

At least I think the XXX is probably referring to the evil use of ALIGN?

This revision is now accepted and ready to land.Dec 22 2025, 10:10 AM
markj added inline comments.Dec 22 2025, 3:18 PM
contrib/telnet/telnet/commands.c
2851

I had thought so too, but it predates it, see commit c847fdb1f93a7.

Closed by commit rG3a4275a5f1f5: telnet: Remove usage of ALIGN (authored by markj). · Explain WhyDec 22 2025, 3:51 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG3a4275a5f1f5: telnet: Remove usage of ALIGN.
markj added a commit: rGeb92fbcadeec: telnet: Remove usage of ALIGN.Dec 29 2025, 5:07 PM

Revision Contents
Changeset List

PathSize
contrib/
telnet/
telnet/
4 lines

Diff 168520

View Options

contrib/telnet/telnet/commands.c

Loading...