Page MenuHomeFreeBSD

bhyvectl: improve options error handling
Needs ReviewPublic

Authored by novel on Fri, Dec 5, 7:09 PM.

Details

Reviewers
None
Group Reviewers
bhyve
Summary

Currently, it's possible to execute bhyvectl(8) with mutually exclusive
options, such as "--destroy" and "--suspend", and it will print out
obscure errors, e.g.:

bhyvectl --suspend=/var/run/vms/my_vm --destroy --vm my_vm
connect() failed: Connection refused

Address that by failing early if mutually exclusive options were
specified.

Additionally, move the BHYVE_SNAPSHOT block before the errors are
printed, so its errors are also displayed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69080
Build 65963: arc lint + arc unit