Page MenuHomeFreeBSD

libjail: start refactoring struct ioctl support
AcceptedPublic

Authored by kevans on Thu, Nov 27, 6:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 15, 9:37 PM
Unknown Object (File)
Sat, Dec 6, 9:38 AM
Unknown Object (File)
Sat, Dec 6, 6:19 AM
Unknown Object (File)
Fri, Dec 5, 7:20 PM
Unknown Object (File)
Thu, Dec 4, 4:54 PM
Unknown Object (File)
Tue, Dec 2, 10:49 AM
Subscribers

Details

Reviewers
csjp
olce
jamie
Group Reviewers
Jails
Summary

Instead of ad-hoc comparisons against the struct type in a few places,
start to abstract out an interface for dealing with struct types. For
now, this just means that we have some special jailparam_import and
jailparam_export handling for the ip addr types, but in the next commit
we'll extend it further to support MAC labels.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68898
Build 65781: arc lint + arc unit

Event Timeline

jamie added a subscriber: jamie.

The original author should have done this in the first place ;-)

lib/libjail/jail.c
83

You're optimistic about our coding speed :-)

This revision is now accepted and ready to land.Tue, Dec 2, 4:25 AM

Don't have time to review this in detail, but overall you have my blessing as well. :-)