Page MenuHomeFreeBSD
Differential D53946

libcasper: fix warnings when _ALIGN preserves types
Needs ReviewPublic
Actions

Authored by brooks on Thu, Nov 27, 3:34 PM.

Details

Reviewers
kib
Group Reviewers
cheri
Summary

Without the void * casts, the compiler complains about an allignment
requirement increase.

Obtained from: CheriBSD
Effort: CHERI upstreaming
Sponsored by: DARPA, AFRL

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 68887
Build 65770: arc lint + arc unit

Event Timeline

brooks created this revision.Thu, Nov 27, 3:34 PM
Herald added a subscriber: imp. · View Herald TranscriptThu, Nov 27, 3:34 PM
brooks requested review of this revision.Thu, Nov 27, 3:34 PM
Harbormaster completed remote builds in B68887: Diff 167185.Thu, Nov 27, 3:34 PM
brooks added a parent revision: D53945: get*ent: be consistant about _ALIGN(p) - p.Thu, Nov 27, 3:34 PM
brooks added a child revision: D53947: Add sys/_align.h replacing machine/_align.h.
brooks removed a parent revision: D53945: get*ent: be consistant about _ALIGN(p) - p.Thu, Nov 27, 3:34 PM
kib added inline comments.Fri, Nov 28, 12:57 AM
lib/libcasper/services/cap_grp/cap_grp.c
105

I do not understand neither the old code, nor the new one.
After *bufferp is evaluated, we get the char * value, which is then aligned. Why is it cast to char ** at all?

Revision Contents
Changeset List

PathSize
lib/
libcasper/
services/
cap_grp/
4 lines

Diff 167185

View Options

lib/libcasper/services/cap_grp/cap_grp.c

Loading...