examples/jails: Allow any character in interface names
Needs ReviewPublic
Actions

Authored by jlduran on Fri, Nov 21, 7:41 PM.

Details

Reviewers

dteske

Group Reviewers

Jails

Summary

Interface names have no limitations on the allowed character set, only
a length restriction.

Widen the allowed character set for interface names to include any
printable character.

PR: 290916

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68791
Build 65674: arc lint + arc unit

Event Timeline

jlduran created this revision.Fri, Nov 21, 7:41 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Nov 21, 7:41 PM

jlduran requested review of this revision.Fri, Nov 21, 7:41 PM

Harbormaster completed remote builds in B68790: Diff 166923.Fri, Nov 21, 7:41 PM

jlduran added a reviewer: Jails.Fri, Nov 21, 7:43 PM

Include the same pattern in jib_destroy(), jng_shutdown(), and jng_stats().

Harbormaster completed remote builds in B68791: Diff 166924.Fri, Nov 21, 8:05 PM

Using tabs, spaces or newlines in interface names is just asking for trouble. A lot of the rc.d shell code is not properly written to deal with such intentional stupidity.

In D53865#1230620, @crest_freebsd_rlwinm.de wrote:

Using tabs, spaces or newlines in interface names is just asking for trouble. A lot of the rc.d shell code is not properly written to deal with such intentional stupidity.

Right, I agree, I believe isprint(3) does not include those...
Probably the original pattern stems from rc.subr (*[!a-zA-Z0-9_]). If I remember correctly, @dteske preferred creating jails using rc.conf and not jail.conf (a vague recollection of some YouTube video).

jlduran added a reviewer: dteske.Fri, Nov 21, 10:55 PM

Interesting.

BastilleBSD has code to automatically sed ‘s/-/_/‘ for the /etc/rc.conf part when jail names contain a hyphen.

I would at least consider allowing (.) as they are very common when using vlan with interfaces.