nvme: Use memcpy instead of memmove in nvme_cdata_get_disk_ident
ClosedPublic
Actions

Authored by jhb on Thu, Nov 20, 2:52 PM.

Details

Reviewers

imp
asomers

Commits

rG44d6df4f65b1: nvme: Use memcpy instead of memmove in nvme_cdata_get_disk_ident

Summary

These buffers should not overlap.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Thu, Nov 20, 2:52 PM

Herald added a subscriber: dab. · View Herald TranscriptThu, Nov 20, 2:52 PM

jhb requested review of this revision.Thu, Nov 20, 2:52 PM

Harbormaster completed remote builds in B68767: Diff 166850.Thu, Nov 20, 2:52 PM

memmove -> memcpy is the right thing because sn and cddata->sn can't possibly overlap.

sys/dev/nvme/nvme.h
31–32	This is OBE. I committed, without review, this change earlier today. I had missed this review until I was doing a deep-dive into my unread email. mea culpa.

This revision is now accepted and ready to land.Wed, Nov 26, 3:02 AM

jhb added inline comments.Mon, Dec 1, 2:52 PM

sys/dev/nvme/nvme.h
31–32	No worries.

jhb retitled this revision from nvme: Small cleanups to <dev/nvme/nvme.h> to nvme: Use memcpy instead of memmove in nvme_cdata_get_disk_ident.Tue, Dec 2, 3:56 PM

jhb edited the summary of this revision. (Show Details)

Closed by commit rG44d6df4f65b1: nvme: Use memcpy instead of memmove in nvme_cdata_get_disk_ident (authored by jhb). · Explain WhyTue, Dec 2, 4:02 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG44d6df4f65b1: nvme: Use memcpy instead of memmove in nvme_cdata_get_disk_ident.