It's rather important option if you use for anything more advanced than plain PC. Over the years I found it's extremely strange that such important option is not documented at all.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/boot/forth/loader.conf.5 | ||
|---|---|---|
| 116 ↗ | (On Diff #13440) | That seems a little confusing. By definition, it has to be in a way the kernel understands. How about just: Specify the root partition to mount. |
| 121 ↗ | (On Diff #13440) | "Normally" is not needed: The value of this tunable is automatically set by |
| 125 ↗ | (On Diff #13440) | How about This parameter can be set manually when the calculated value is not correct. That can happen when .Pa /etc/fstab is inaccessible at the time .Xr loader 8 runs, like during diskless booting from NFS. |
Comment Actions
Done, new diff is up please check. Thanks!
| sys/boot/forth/loader.conf.5 | ||
|---|---|---|
| 125 ↗ | (On Diff #13440) | Accepted, mostly, I've dropped "manually" since we are talking about loader.conf, since it might pretty well be permanent override, while "manually" to me implies doing it via loader's CLI. Also blended in with some of the @imp's comments below. Please check the new revision. |
| 131 ↗ | (On Diff #13440) | Blended with some of the suggestions from wblock above. It becomes quite long, not sure if something can be dropped without reducing the clarity. |
| sys/boot/forth/loader.conf.5 | ||
|---|---|---|
| 125 ↗ | (On Diff #13450) | The problem is that "can be set" is vague about who is doing the setting, the user or the system. Maybe "can be set by the user"? And "is known to be incorrect" is not really different from just "incorrect". |
| 126 ↗ | (On Diff #13450) | Not really clear what this means. Possibly there are too many things being combined and it would be easier to separate them. .Xr loader 8 automatically calculates the value of this tunable from .Pa /etc/fstab . The calculated value can be incorrect when .Pa /etc/fstab is not available during .Xr loader 8 startup (as during diskless booting from NFS), or if a different device is desired by the user. The preferred value can be set in .Pa /loader.conf . |
| 138 ↗ | (On Diff #13450) | This should probably be two sentences: The value can also be overridden from the .Xr loader 8 command line. This is useful for system recovery when .Pa /etc/fstab is damaged, lost, or read from the wrong partition. |
Comment Actions
commit aac88dd0e247cc7392b40e07750c338113faded1
Author: Maksym Sobolyev <sobomax@sippysoft.com>
Date: Thu Feb 18 15:21:05 2016 -0800
Include suggestions from @imp and @wblock.
Comment Actions
commit 38a3f85028494f7f5a6b361467a544d3363f35e6
Author: Maksym Sobolyev <sobomax@sippysoft.com>
Date: Tue Feb 23 11:47:58 2016 -0800
Some more fixes from @wblock.
Comment Actions
Remember that .Dd must be updated. Always good to run igor -R loader.conf.5 | less -RS and mandoc -Tlint loader.conf.5, too.
| sys/boot/forth/loader.conf.5 | ||
|---|---|---|
| 124 ↗ | (On Diff #13657) | "can be incorrect" is easy to read as "is allowed to be wrong", but really means "might be calculated incorrectly". |
| 126 ↗ | (On Diff #13657) | Missing an "is" for "is not". |
Comment Actions
One final niggle.
| sys/boot/forth/loader.conf.5 | ||
|---|---|---|
| 124 ↗ | (On Diff #13657) | You might want to add after /etc/fstab "from the partition the kernel was loaded from" to be specific about how it finds /etc/fstab to look at. |