Page MenuHomeFreeBSD
Differential D5328

Fix compiler warnings in iostat
ClosedPublic
Actions

Authored by asomers on Feb 18 2016, 6:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 23, 1:34 AM
Unknown Object (File)
Sat, Nov 22, 11:16 PM
Unknown Object (File)
Sat, Nov 22, 9:21 PM
Unknown Object (File)
Fri, Nov 21, 6:53 PM
Unknown Object (File)
Thu, Nov 20, 6:23 PM
Unknown Object (File)
Thu, Nov 20, 6:20 PM
Unknown Object (File)
Thu, Nov 20, 6:19 PM
Unknown Object (File)
Thu, Nov 20, 6:08 PM
View All Files
Subscribers
imp

Details

Reviewers
eadler
Commits
rS295768: Fix compiler warnings in iostat
Summary

Raise WARNS from 1 to 6 (the default)
Fix warnings:

  • Use C99 designated initializers for structs, and initialize all
	  fields
  • Mark global variables as static
  • Mark unused function arguments
  • Be careful about signed/unsigned comparisons

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers updated this revision to Diff 13434.Feb 18 2016, 6:42 PM
asomers retitled this revision from to Fix compiler warnings in iostat.
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added a reviewer: eadler.
Herald added a subscriber: imp. · View Herald TranscriptFeb 18 2016, 6:42 PM
eadler accepted this revision.Feb 18 2016, 7:35 PM
eadler edited edge metadata.
This revision is now accepted and ready to land.Feb 18 2016, 7:35 PM
Closed by commit rS295768: Fix compiler warnings in iostat (authored by asomers). · Explain WhyFeb 18 2016, 8:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
iostat/
2 lines
47 lines

Diff 13438

View Options

head/usr.sbin/iostat/Makefile

Loading...
View Options

head/usr.sbin/iostat/iostat.c

Loading...