Page MenuHomeFreeBSD
Differential D5328

Fix compiler warnings in iostat
ClosedPublic
Actions

Authored by asomers on Feb 18 2016, 6:42 PM.
Tags
None
Referenced Files
F83178992: D5328.diff
Tue, May 7, 8:47 AM
Unknown Object (File)
Fri, Apr 26, 5:27 AM
Unknown Object (File)
Fri, Apr 26, 5:19 AM
Unknown Object (File)
Mar 12 2024, 10:09 AM
Unknown Object (File)
Mar 12 2024, 10:09 AM
Unknown Object (File)
Mar 12 2024, 10:09 AM
Unknown Object (File)
Mar 8 2024, 5:37 AM
Unknown Object (File)
Feb 24 2024, 6:03 AM
View All 69 Files
Subscribers
imp

Details

Reviewers
eadler
Commits
rS295768: Fix compiler warnings in iostat
Summary

Raise WARNS from 1 to 6 (the default)
Fix warnings:

  • Use C99 designated initializers for structs, and initialize all
	  fields
  • Mark global variables as static
  • Mark unused function arguments
  • Be careful about signed/unsigned comparisons

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2550
Build 2567: arc lint + arc unit

Event Timeline

asomers updated this revision to Diff 13434.Feb 18 2016, 6:42 PM
asomers retitled this revision from to Fix compiler warnings in iostat.
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added a reviewer: eadler.
Herald added a subscriber: imp. · View Herald TranscriptFeb 18 2016, 6:42 PM
eadler accepted this revision.Feb 18 2016, 7:35 PM
eadler edited edge metadata.
This revision is now accepted and ready to land.Feb 18 2016, 7:35 PM
Closed by commit rS295768: Fix compiler warnings in iostat (authored by asomers). · Explain WhyFeb 18 2016, 8:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.sbin/
iostat/
2 lines
47 lines

Diff 13434

View Options

usr.sbin/iostat/Makefile

Loading...
View Options

usr.sbin/iostat/iostat.c

Loading...