Differential D53226

cut: Avoid undefined behavior.
ClosedPublic
Actions

Authored by bdrewery on Mon, Oct 20, 7:06 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 22, 10:53 PM

	Unknown Object (File)
	Wed, Oct 22, 10:53 PM

	Unknown Object (File)
	Wed, Oct 22, 2:10 PM

	Unknown Object (File)
	Wed, Oct 22, 2:13 AM

	Unknown Object (File)
	Tue, Oct 21, 3:22 PM

	Unknown Object (File)
	Tue, Oct 21, 10:42 AM

	Unknown Object (File)
	Tue, Oct 21, 5:42 AM

	Unknown Object (File)
	Tue, Oct 21, 12:33 AM

View All 10 Files

Subscribers

Details

Reviewers

Commits

rG35f375549c7f: cut: Avoid undefined behavior.

Summary

UBSAN complains about p[signed - unsigned] wrapping around.

Test Plan

# make all install check
...
cut2_test:s_flag  ->  passed  [0.061s]
cut_test:basic  ->  passed  [0.070s]
cut_test:dflag  ->  passed  [0.062s]
cut_test:dsflag  ->  passed  [0.059s]
cut_test:latin1  ->  passed  [0.040s]
cut_test:sflag  ->  passed  [0.064s]
cut_test:utf8  ->  passed  [0.042s]

Results file id is scratch_obj_root_git_freebsd_main2_amd64.amd64_usr.bin_cut_tests_checkdir_usr_tests_usr.bin_cut.20251020-190514-964826
Results saved to /root/.kyua/store/results.scratch_obj_root_git_freebsd_main2_amd64.amd64_usr.bin_cut_tests_checkdir_usr_tests_usr.bin_cut.20251020-190514-964826.db

7/7 passed (0 broken, 0 failed, 0 skipped)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdrewery created this revision.Mon, Oct 20, 7:06 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Oct 20, 7:06 PM

bdrewery requested review of this revision.Mon, Oct 20, 7:06 PM

Harbormaster completed remote builds in B67948: Diff 164650.Mon, Oct 20, 7:06 PM

kevans accepted this revision.Mon, Oct 20, 7:09 PM

This revision is now accepted and ready to land.Mon, Oct 20, 7:09 PM

Closed by commit rG35f375549c7f: cut: Avoid undefined behavior. (authored by bdrewery). · Explain WhyFri, Oct 24, 12:03 AM

This revision was automatically updated to reflect the committed changes.

bdrewery added a commit: rG35f375549c7f: cut: Avoid undefined behavior..

Revision Contents
Changeset List

Path

Size

usr.bin/

cut/

4 lines

Diff 164934

usr.bin/cut/cut.c

Loading...