Page MenuHomeFreeBSD
Differential D53186

release: split up Oracle Cloudware tools
AcceptedPublic
Actions

Authored by dch on Sat, Oct 18, 12:41 PM.
Tags
None
Referenced Files
F132637124: D53186.id.diff
Sat, Oct 18, 3:45 PM
F132636933: D53186.id164494.diff
Sat, Oct 18, 3:43 PM
F132633696: D53186.id164494.diff
Sat, Oct 18, 3:00 PM
F132631518: D53186.diff
Sat, Oct 18, 2:35 PM
F132631513: D53186.diff
Sat, Oct 18, 2:35 PM
Subscribers
imp
ivy
jrtc27

Details

Reviewers
cperciva
Group Reviewers
releng
Summary

Sometimes one or the other but not both tools are present; this ensures
that all cases are correctly handled.

Reported by: cperciva
Sponsored by: SkunkWerks, GmbH

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67897
Build 64780: arc lint + arc unit

Event Timeline

dch created this revision.Sat, Oct 18, 12:41 PM
Herald added subscribers: ivy, jrtc27, imp. · View Herald TranscriptSat, Oct 18, 12:41 PM
dch requested review of this revision.Sat, Oct 18, 12:41 PM
Harbormaster completed remote builds in B67897: Diff 164494.Sat, Oct 18, 12:41 PM
dch added reviewers: releng, cperciva.Sat, Oct 18, 1:00 PM
ivy added inline comments.Sat, Oct 18, 1:03 PM
release/Makefile.oracle
30

not a review (i'm not familiar with this code at all) but as a general suggestion, it might be nice to use ${LOCALBASE} here rather than hardcoding /usr/local. i'm trying to get all of release/ to do this, although it's a fairly long-term project.

cperciva accepted this revision.Sun, Oct 19, 4:01 AM

LGTM. Please commit, MFC After: 3 days, and poke me to cherry-pick to releng/15.0 before BETA3.

This revision is now accepted and ready to land.Sun, Oct 19, 4:01 AM

Revision Contents
Changeset List

PathSize
release/
19 lines

Diff 164494

View Options

release/Makefile.oracle

Loading...