Paths

Table of Contentst

Differential D53186

release: split up Oracle Cloudware tools
ClosedPublic
Actions

Authored by dch on Sat, Oct 18, 12:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 9, 12:04 AM

	Unknown Object (File)
	Thu, Nov 6, 11:36 PM

	Unknown Object (File)
	Tue, Nov 4, 2:56 AM

	Unknown Object (File)
	Mon, Nov 3, 9:12 AM

	Unknown Object (File)
	Sat, Nov 1, 9:12 PM

	Unknown Object (File)
	Thu, Oct 30, 5:51 PM

	Unknown Object (File)
	Thu, Oct 30, 4:16 PM

	Unknown Object (File)
	Wed, Oct 29, 5:25 PM

View All 27 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGb6cde3ca5dbf: release: split up Oracle Cloudware tools
rGe27e5b6b0177: release: split up Oracle Cloudware tools
rG81d807a90611: release: split up Oracle Cloudware tools

Summary

Sometimes one or the other but not both tools are present; this ensures
that all cases are correctly handled.

Reported by: cperciva
Sponsored by: SkunkWerks, GmbH

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dch created this revision.Sat, Oct 18, 12:41 PM

Herald added subscribers: ivy, jrtc27, imp. · View Herald TranscriptSat, Oct 18, 12:41 PM

dch requested review of this revision.Sat, Oct 18, 12:41 PM

Harbormaster completed remote builds in B67897: Diff 164494.Sat, Oct 18, 12:41 PM

dch added reviewers: releng, cperciva.Sat, Oct 18, 1:00 PM

ivy added inline comments.Sat, Oct 18, 1:03 PM

release/Makefile.oracle
30–31	not a review (i'm not familiar with this code at all) but as a general suggestion, it might be nice to use `${LOCALBASE}` here rather than hardcoding `/usr/local`. i'm trying to get all of release/ to do this, although it's a fairly long-term project.

LGTM. Please commit, MFC After: 3 days, and poke me to cherry-pick to releng/15.0 before BETA3.

This revision is now accepted and ready to land.Sun, Oct 19, 4:01 AM

Closed by commit rG81d807a90611: release: split up Oracle Cloudware tools (authored by dch). · Explain WhyMon, Oct 20, 9:38 AM

This revision was automatically updated to reflect the committed changes.

dch added a commit: rG81d807a90611: release: split up Oracle Cloudware tools.

dch added inline comments.Mon, Oct 20, 1:16 PM

release/Makefile.oracle
30–31	this is a very good idea, but I'll leave it til after BETA3 goes through as I'm wary of breaking yet another build. Once I MFC this, I can add this to CURRENT & STABLE alone. I copy-pasta-ed it from the AWS EC2 images so we could change all of them across the board.

dch added a commit: rGe27e5b6b0177: release: split up Oracle Cloudware tools.Wed, Oct 22, 8:17 AM

dch added a commit: rGb6cde3ca5dbf: release: split up Oracle Cloudware tools.Wed, Oct 22, 8:25 AM

Revision Contents
Changeset List

Path

Size

release/

Makefile.oracle

19 lines

Diff 164583

release/Makefile.oracle

Loading...